jfx
jfx copied to clipboard
8358802: Update boot JDK to 24.0.1
Support for JDK 24 was added in Gradle 8.14.2. Hence update bootjdk to JDK 24.0.1 and gradle to 8.14.2 No changes to gradle build script were needed for this upgrade.
/issue add JDK-8358800
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [x] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)
Issues
- JDK-8358802: Update boot JDK to 24.0.1 (Bug - P3)
- JDK-8358800: Update Gradle to 8.14.2 (Bug - P3)
Reviewers
- Kevin Rushforth (@kevinrushforth - Reviewer)
- Joeri Sykora (@tiainen - Author)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1832/head:pull/1832
$ git checkout pull/1832
Update a local copy of the PR:
$ git checkout pull/1832
$ git pull https://git.openjdk.org/jfx.git pull/1832/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1832
View PR using the GUI difftool:
$ git pr show -t 1832
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1832.diff
Using Webrev
:wave: Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@arapte This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
8358802: Update boot JDK to 24.0.1
8358800: Update Gradle to 8.14.2
Reviewed-by: kcr, sykora
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 2 new commits pushed to the master branch:
- f9e879225964f2ed2359cfc83accff674c476513: 8359896: [TestBug][JUnit5] Possible configuration error
- 4257aa9fb96f3ed1b7e59ab0f4f62a13909e272c: 8359396: [Linux] Require Gtk3 >= 3.20 for glass-gtk
Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
@arapte
Adding additional issue to issue list: 8358800: Update Gradle to 8.14.2.
Reviewers: @kevinrushforth @tiainen or @johanvos
/reviewers 2
@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).
Please merge in the latest master to get the updated gradle wrapper-validation action (since you are updating the gradle wrapper, I'd like to see a GHA run with the newer action).
/integrate
@arapte An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.
/integrate
@arapte An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.
/integrate
Going to push as commit fc4642dbb008ed0e49996c1eea10b92fad5f7dcf.
Since your change was applied there have been 2 commits pushed to the master branch:
- f9e879225964f2ed2359cfc83accff674c476513: 8359896: [TestBug][JUnit5] Possible configuration error
- 4257aa9fb96f3ed1b7e59ab0f4f62a13909e272c: 8359396: [Linux] Require Gtk3 >= 3.20 for glass-gtk
Your commit was automatically rebased without conflicts.
@arapte Pushed as commit fc4642dbb008ed0e49996c1eea10b92fad5f7dcf.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.