jfx icon indicating copy to clipboard operation
jfx copied to clipboard

8359387: Bump minimum JDK version for JavaFX to JDK 23

Open kevinrushforth opened this issue 5 months ago • 7 comments
trafficstars

This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 23.

In order for JavaFX to be able to use more recent JDK features, we should increase the minimum version of the JDK that can run the latest JavaFX. Additionally, there is an ongoing cost to keeping JavaFX buildable and runnable on older versions of Java, and little reason to continue to do so.

This continues our recent practice of setting the minimum JDK for JavaFX N to JDK N-2. JavaFX N is primarily intended for use with JDK N and we also build and test it against JDK N-1 (which is typically what we use as the boot JDK). Anything older than that, including the proposed minimum JDK N-2 (23 in this specific case), is untested.

This PR targeted to JavaFX 25, and must not be backported to any earlier version. This needs a CSR and a release note.

/reviewers 2 /csr


Progress

  • [ ] Change requires CSR request JDK-8359467 to be approved
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

  • JDK-8359387: Bump minimum JDK version for JavaFX to JDK 23 (Enhancement - P3)
  • JDK-8359467: Bump minimum JDK version for JavaFX to JDK 23 (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1827/head:pull/1827
$ git checkout pull/1827

Update a local copy of the PR:
$ git checkout pull/1827
$ git pull https://git.openjdk.org/jfx.git pull/1827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1827

View PR using the GUI difftool:
$ git pr show -t 1827

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1827.diff

Using Webrev

Link to Webrev Comment

kevinrushforth avatar Jun 13 '25 17:06 kevinrushforth

:wave: Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 13 '25 17:06 bridgekeeper[bot]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359387: Bump minimum JDK version for JavaFX to JDK 23

Reviewed-by: arapte, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jun 13 '25 17:06 openjdk[bot]

@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

openjdk[bot] avatar Jun 13 '25 17:06 openjdk[bot]

@kevinrushforth an approved CSR request is already required for this pull request.

openjdk[bot] avatar Jun 13 '25 17:06 openjdk[bot]

Reviewers: @arapte @johanvos @tiainen

kevinrushforth avatar Jun 17 '25 15:06 kevinrushforth

Webrevs

mlbridge[bot] avatar Jun 17 '25 15:06 mlbridge[bot]

Thanks for the reviews. I'll file the CSR, but let it sit for a while to also give others a chance to review or reply to the thread on the openjfx-dev mailing list.

I will also need to merge master some time after #1832 is integrated, since there will be a (trivial) merge conflict for me to resolve.

kevinrushforth avatar Jun 18 '25 17:06 kevinrushforth

I will also need to merge master some time after #1832 is integrated, since there will be a (trivial) merge conflict for me to resolve.

This is now merged. The trivial conflict was in the surrounding context, not the diffs themselves.

@tiainen @arapte Can you re-review?

kevinrushforth avatar Jul 08 '25 20:07 kevinrushforth

/integrate

kevinrushforth avatar Jul 09 '25 19:07 kevinrushforth

Going to push as commit 6029e3e4058e2a87ecb0f5c07689f7d4783a1c65.

openjdk[bot] avatar Jul 09 '25 19:07 openjdk[bot]

@kevinrushforth Pushed as commit 6029e3e4058e2a87ecb0f5c07689f7d4783a1c65.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jul 09 '25 19:07 openjdk[bot]