jfx
jfx copied to clipboard
openjdk
6586559: Support for vertex colors
Implements vertex color support for TriangleMesh. Demonstrates a possible implementation of this feature proposal.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Error
⚠️ OCA signatory status must be verified
Issue
- JDK-6586559: Support for vertex colors (Enhancement - P5)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1557/head:pull/1557
$ git checkout pull/1557
Update a local copy of the PR:
$ git checkout pull/1557
$ git pull https://git.openjdk.org/jfx.git pull/1557/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1557
View PR using the GUI difftool:
$ git pr show -t 1557
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1557.diff
Hi @Kneesnap, welcome to this OpenJDK project and thanks for contributing!
We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.
If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Kneesnap" as summary for the issue.
If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
Dear reviewers, an application available for manual testing is available by running
C:\Program Files\Java\jdk-21\bin\java" -cp "{PATH TO JFX REPOSITORY}\apps\toys\FX8-3DFeatures\dist\FX8-3DFeatures.jar" --module-path "{PATH TO JFX REPOSITORY}\build\sdk\lib" --add-modules=javafx.controls,javafx.graphics fx83dfeatures.DynamicMeshViewer (You can run in any other way too)
@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
New comment to avoid closure.
On Wed, Oct 16, 2024, 7:39 PM bridgekeeper[bot] @.***> wrote:
@Kneesnap https://github.com/Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-2418371573, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYN6S2NB5ZUIWPF4JZTZ34PPHAVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJYGM3TCNJXGM . You are receiving this because you were mentioned.Message ID: @.***>
@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Keep open! I'll take this as a reminder to finish this.
On Wed, Nov 13, 2024, 7:01 PM bridgekeeper[bot] @.***> wrote:
@Kneesnap https://github.com/Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-2475313544, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYL55ERP53SWL22ZBQD2AQG7ZAVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZVGMYTGNJUGQ . You are receiving this because you were mentioned.Message ID: @.***>
@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Keep open
On Wed, Dec 11, 2024, 11:02 PM bridgekeeper[bot] @.***> wrote:
@Kneesnap https://github.com/Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-2537973621, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYP7XDFS43QWW7P42GL2FEYKBAVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXHE3TGNRSGE . You are receiving this because you were mentioned.Message ID: @.***>
@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Keep open
On Sat, Jan 11, 2025, 9:22 PM bridgekeeper[bot] @.***> wrote:
@Kneesnap https://github.com/Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-2585592721, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYPGZJM2E24RBNY5KCD2KH3Z7AVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVGU4TENZSGE . You are receiving this because you were mentioned.Message ID: @.***>
@Kneesnap this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:
git checkout features/vertex-color-shading
git fetch https://git.openjdk.org/jfx.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push
@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Keep open, I've been a bit busy but I've not forgotten/will complete this.
On Sat, Feb 8, 2025, 11:30 PM bridgekeeper[bot] @.***> wrote:
@Kneesnap https://github.com/Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-2646107151, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYKGMFC6ODH7DQSFSLD2O37ZXAVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBWGEYDOMJVGE . You are receiving this because you were mentioned.Message ID: @.***>
@Kneesnap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Moving this to Draft, since it isn't (yet) ready for review. That will also give extra time before the bot auto-closes it.
Great, thank you Kevin.
On Mon, Mar 10, 2025, 5:56 AM Kevin Rushforth @.***> wrote:
Moving this to Draft, since it isn't (yet) ready for review. That will also give extra time before the bot auto-closes it.
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-2710495954, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYJDK7QPZ7WTULSLX732TWKZ5AVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJQGQ4TKOJVGQ . You are receiving this because you were mentioned.Message ID: @.***> [image: kevinrushforth]kevinrushforth left a comment (openjdk/jfx#1557) https://github.com/openjdk/jfx/pull/1557#issuecomment-2710495954
Moving this to Draft, since it isn't (yet) ready for review. That will also give extra time before the bot auto-closes it.
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-2710495954, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYJDK7QPZ7WTULSLX732TWKZ5AVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJQGQ4TKOJVGQ . You are receiving this because you were mentioned.Message ID: @.***>
@Kneesnap This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Keep open
On Mon, May 5, 2025, 3:41 PM bridgekeeper[bot] @.***> wrote:
bridgekeeper[bot] left a comment (openjdk/jfx#1557) https://github.com/openjdk/jfx/pull/1557#issuecomment-2852522223
@Kneesnap https://github.com/Kneesnap This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-2852522223, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYJA7I2GVHGK7UFHXV3247SLBAVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJSGUZDEMRSGM . You are receiving this because you were mentioned.Message ID: @.***>
@Kneesnap This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/keepalive
On Sat, Jul 5, 2025, 11:52 AM bridgekeeper[bot] @.***> wrote:
bridgekeeper[bot] left a comment (openjdk/jfx#1557) https://github.com/openjdk/jfx/pull/1557#issuecomment-3039687679
@Kneesnap https://github.com/Kneesnap This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
— Reply to this email directly, view it on GitHub https://github.com/openjdk/jfx/pull/1557#issuecomment-3039687679, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYOANOT3RQQY3J3NODT3HANFVAVCNFSM6AAAAABNZOD6A2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZZGY4DONRXHE . You are receiving this because you were mentioned.Message ID: @.***>
@Kneesnap The pull request is being re-evaluated and the inactivity timeout has been reset.
@Kneesnap This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@Kneesnap The pull request is being re-evaluated and the inactivity timeout has been reset.