8324327: ColorPicker shows a white rectangle on clicking on picker

[andy-goryachev-oracle]

trafficstars

Root cause: premature 'return' from initialization code leaves the hover square visible, even when it should be hidden, as the case is when the color value is not present in the palette.

• added unit tests

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8324327: ColorPicker shows a white rectangle on clicking on picker (Bug - P4)

Reviewers

• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1458/head:pull/1458
$ git checkout pull/1458

Update a local copy of the PR:
$ git checkout pull/1458
$ git pull https://git.openjdk.org/jfx.git pull/1458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1458

View PR using the GUI difftool:
$ git pr show -t 1458

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1458.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324327: ColorPicker shows a white rectangle on clicking on picker

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge[bot]]

Webrevs

• 00: Full (31c1d053)

[andy-goryachev-oracle]

hoverSquare's visible property is not initialized in the ColorPalette constructor.

thank you for reviewing, @arapte !

effectively, yes, and that's the issue I have fixed, by explicitly setting visibility in setFocusedSquare() (which is called from the constructor). I think this is a better fix because it fixes the logic in this method which may be applicable in other cases. Setting false to a boolean property which is already false has very little overhead.

[andy-goryachev-oracle]

/integrate

[openjdk[bot]]

Going to push as commit 9dc4aa2341581d730c9d721e91ac0da081ffddcc.

[openjdk[bot]]

@andy-goryachev-oracle Pushed as commit 9dc4aa2341581d730c9d721e91ac0da081ffddcc.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.