8325591: [Mac] DRAG_DONE reports null transferMode when destination is external

[beldenfox]

trafficstars

At the end of a drag operation the Mac Glass code sends out a DRAG_DONE event using the operation mask tracked in the GlassDragSource to determine the final transfer mode. That mask is only updated when a window in the JavaFX app is the drop destination. If the drag moves to an external destination the mask is set to NONE. If the drag terminates in the external destination that NONE forms the basis of the transfer mode sent via the DRAG_DONE event.

At the very end of the drag the OS calls the NSDraggingSource (GlassDraggingSource) with the final drag operation. This PR issues the DRAG_DONE from that callback so it can get the final transfer mode correct for both internal and external destinations.

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8325591: [Mac] DRAG_DONE reports null transferMode when destination is external (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1371/head:pull/1371
$ git checkout pull/1371

Update a local copy of the PR:
$ git checkout pull/1371
$ git pull https://git.openjdk.org/jfx.git pull/1371/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1371

View PR using the GUI difftool:
$ git pr show -t 1371

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1371.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back mfox! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge[bot]]

Webrevs

• 03: Full - Incremental (e2052e9d)
• 02: Full - Incremental (4eed575a)
• 01: Full - Incremental (c0bbbf5c)
• 00: Full (4f088cc3)

[kevinrushforth]

/reviewers 2

[openjdk[bot]]

@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[openjdk[bot]]

@beldenfox This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325591: [Mac] DRAG_DONE reports null transferMode when destination is external

Reviewed-by: lkostyra, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• cac81b52fdeca763f3da21523c1582af3407aaf3: 8331319: IME Window breaks after popup menu

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

Reviewers: @kevinrushforth @lukostyra

[bridgekeeper[bot]]

@beldenfox This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[kevinrushforth]

@lukostyra Can you please re-review?

[beldenfox]

/integrate

[openjdk[bot]]

Going to push as commit aa9907a58e24bc997a6762d62542a9cc6234dbe3. Since your change was applied there has been 1 commit pushed to the master branch:

• cac81b52fdeca763f3da21523c1582af3407aaf3: 8331319: IME Window breaks after popup menu

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@beldenfox Pushed as commit aa9907a58e24bc997a6762d62542a9cc6234dbe3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.