jfx
jfx copied to clipboard
openjdk
8242616: Regression: RTL - TextField Cursor Movement Via Keyboard
The old logic for cursor movement was buggy when both RTL and LTR text was present in the TextField. Used character BreakIterator instead of finding the character index using hitTest.
Added system test to validate the fix.
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)
Issue
- JDK-8242616: Regression: RTL - TextField Cursor Movement Via Keyboard (Bug - P3)
Contributors
- Andy Goryachev
<[email protected]>
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1222/head:pull/1222
$ git checkout pull/1222
Update a local copy of the PR:
$ git checkout pull/1222
$ git pull https://git.openjdk.org/jfx.git pull/1222/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1222
View PR using the GUI difftool:
$ git pr show -t 1222
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1222.diff
Webrev
:wave: Welcome back kpk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
The fix is similar to the solution proposed by @andy-goryachev-oracle in PR#1220 hence added as contributor.
@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).
@karthikpandelu This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Since the navigation and behavior at bidi text boundary is not clear, converting this PR to draft. The PR#1220 on which this PR is dependent is also converted to draft.
@karthikpandelu This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@karthikpandelu This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@karthikpandelu This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@karthikpandelu This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!