jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working

Open sendaoYan opened this issue 1 month ago • 7 comments

Hi all,

This backport PR partial fix the test bug, which may cause test fails without swapping memory. Change has been verified locally. Test-fix only, no risk. This backport will make later backport JDK-8343340 cleanly.

Only the different copyright year cause this backport uncleanly. Other parts are backport cleanly.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8264524 needs maintainer approval

Issue

  • JDK-8264524: jdk/internal/platform/docker/TestDockerMemoryMetrics.java fails due to swapping not working (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/708/head:pull/708
$ git checkout pull/708

Update a local copy of the PR:
$ git checkout pull/708
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 708

View PR using the GUI difftool:
$ git pr show -t 708

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/708.diff

Using Webrev

Link to Webrev Comment

sendaoYan avatar Oct 24 '25 06:10 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 24 '25 06:10 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Oct 24 '25 06:10 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Oct 24 '25 06:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 24 '25 06:10 mlbridge[bot]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Oct 27 '25 18:10 openjdk[bot]

Thanks for the reviews @phohensee

/approval request Backport to partial fix the test bug, and will make the later backport JDK-8343340 to jdk8u cleanly. Change has been verifiedlocally on linux-x64 which swapping memory is enable. Test-fix only, no risk.

sendaoYan avatar Oct 28 '25 01:10 sendaoYan

@sendaoYan 8264524: The approval request has been created successfully.

openjdk[bot] avatar Oct 28 '25 01:10 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Nov 25 '25 05:11 bridgekeeper[bot]

/approval request Backport to partial fix the test bug, and will make the later backport JDK-8343340 to jdk8u cleanly. Change has been verifiedlocally on linux-x64 which swapping memory is enable. Test-fix only, no risk.

sendaoYan avatar Nov 25 '25 12:11 sendaoYan

@sendaoYan 8264524: The approval request was already up to date.

openjdk[bot] avatar Nov 25 '25 12:11 openjdk[bot]