jdk8u-dev
jdk8u-dev copied to clipboard
8212678: Windows IME related patch
Hi All,
I would like to backport this bug fix (JDK-8212768) done in jdk13 to jdk8. It is basically a clean backport, but only the copyright of awt_InputMethod.cpp and awt_Component.cpp is not updated because the current source is newer.
The following fixes are resolved.
Issue A: Cannot display surrogate pair character on Windows floating IME window for passive component
It has been reproduced using the test program (SwingSet2) in a specific environment and verified that this fix resolves it.
Issue B: Control Windows IME status using InputSubset and UnicodeBlock for CJK countries
It has been reproduced using the test program (ImSubsetsTest.java) in a specific environment and verified that this fix resolves it.
Issue C: Check pre-edit string availability for Windows Chinese IME
It probably won't happen again in the new environment. I have verified that the behavior of the test program (IMFTestA.java) remains unchanged after this fix.
JTREG tests were executed using the -a option (automatic tests only) for the test suites java/awt/Component and java/awt/InputMethods. No failures were found.
The changes implemented in JDK-8212678 alone are not sufficient to fully resolve IME-related issues. To ensure a complete fix, the changes from JDK-8258805 must also be integrated. I plan to create a separate pull request.
Thank you.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8212678 needs maintainer approval
Issue
- JDK-8212678: Windows IME related patch (Bug - P3)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/706/head:pull/706
$ git checkout pull/706
Update a local copy of the PR:
$ git checkout pull/706
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/706/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 706
View PR using the GUI difftool:
$ git pr show -t 706
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/706.diff
Using Webrev
:wave: Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
This backport pull request has now been updated with issue from the original commit.
@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Would anyone be willing to review this? This fix is pretty much clean. The GHA failure is not due to this fix.