jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points

Open sendaoYan opened this issue 1 month ago • 7 comments

Hi all,

This pull request contains a backport of commit b6876649 from the openjdk/jdk repository.

This backport PR try to fix the test bug, test will skip the '/run/user' directory when it throw FileSystemException. This PR add import jdk.test.lib.Platform; and @library /test/lib make this backport uncleanly, other parts are backport cleanly.

Change has been verified locally, test-fix only, no risk.

Thanks!


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8277159 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8277159: Fix java/nio/file/FileStore/Basic.java test by ignoring /run/user/* mount points (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/705/head:pull/705
$ git checkout pull/705

Update a local copy of the PR:
$ git checkout pull/705
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/705/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 705

View PR using the GUI difftool:
$ git pr show -t 705

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/705.diff

Using Webrev

Link to Webrev Comment

sendaoYan avatar Oct 16 '25 03:10 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 16 '25 03:10 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Oct 16 '25 03:10 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Oct 16 '25 03:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 16 '25 03:10 mlbridge[bot]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Oct 20 '25 23:10 openjdk[bot]

Thanks for the reviews @phohensee

/approval request Backport to make test skip the '/run/user' directory when it throw FileSystemException on linux. Change has been verified locally on linux-x64, test-fix only, no risk.

sendaoYan avatar Oct 21 '25 02:10 sendaoYan

@sendaoYan 8277159: The approval request has been created successfully.

openjdk[bot] avatar Oct 21 '25 02:10 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Nov 18 '25 02:11 bridgekeeper[bot]

/approval request Backport to make test skip the '/run/user' directory when it throw FileSystemException on linux. Change has been verified locally on linux-x64, test-fix only, no risk.

sendaoYan avatar Nov 18 '25 03:11 sendaoYan

@sendaoYan 8277159: The approval request was already up to date.

openjdk[bot] avatar Nov 18 '25 03:11 openjdk[bot]