jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError

Open wkia opened this issue 1 month ago • 10 comments
trafficstars

This is backport of "JDK-8350813 Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError"

The problem exists in jdk8 also.

Almost clean backport, resolved conflict in copyright, and put BulkSoundBank.java to jdk/test/javax/sound/midi/BulkSoundBank/.

Test fails before the fix, and passes with the fix.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8350813 needs maintainer approval

Issue

  • JDK-8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/702/head:pull/702
$ git checkout pull/702

Update a local copy of the PR:
$ git checkout pull/702
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 702

View PR using the GUI difftool:
$ git pr show -t 702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/702.diff

Using Webrev

Link to Webrev Comment

wkia avatar Sep 23 '25 12:09 wkia

:wave: Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 23 '25 12:09 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Sep 23 '25 12:09 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Sep 23 '25 12:09 openjdk[bot]

Webrevs

mlbridge[bot] avatar Sep 23 '25 12:09 mlbridge[bot]

The failed CertPathValidator tests don't look related to the change.

wkia avatar Sep 24 '25 08:09 wkia

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 22 '25 18:10 bridgekeeper[bot]

/touch

wkia avatar Oct 22 '25 18:10 wkia

@wkia The pull request is being re-evaluated and the inactivity timeout has been reset.

openjdk[bot] avatar Oct 22 '25 18:10 openjdk[bot]

/approval request I'd like to backport this as the problem also exists in jdk8. This is almost clean backport, resolved conflict in copyright. Test fails before the fix, and passes with the fix.

wkia avatar Oct 28 '25 05:10 wkia

@wkia 8350813: The approval request has been created successfully.

openjdk[bot] avatar Oct 28 '25 05:10 openjdk[bot]