jdk8u-dev
jdk8u-dev copied to clipboard
8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build
Hi all,
Test tools/launcher/VersionCheck.java fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'. This failure fixed by JDK-8237192 in jdk15, only a subset of JDK-8237192 to fix this test failure. So it's not suitable to backport JDK-8237192 to jdk8u-dev, then I create this PR to fix this testbug.
This PR skip all the *.debuginfo files to check the '-version' or '-J-version'. Change has been verified localy, test-fix only, no risk.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8353657 needs maintainer approval
Issue
- JDK-8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build (Bug - P4 - Requested)
Reviewers
- Andrew Haley (@theRealAph - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/685/head:pull/685
$ git checkout pull/685
Update a local copy of the PR:
$ git checkout pull/685
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/685/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 685
View PR using the GUI difftool:
$ git pr show -t 685
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/685.diff
Using Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
GHA report several fails:
- Test CAInterop.java#entrustrootcag4 fails, which has been problemlist by https://github.com/openjdk/jdk8u-dev/pull/696
- Linux x86 hotspot/tier1 job report test gc/logging/TestGCId.java timed out. I think it's unrelated to this PR.
Thanks for the reviews @theRealAph
/approval request Fix the test bug which will cause test fail with jdk fastdebug build. Change has been verified locally, test-fix only, no risk.
@sendaoYan 8353657: The approval request has been created successfully.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval request Fix the test bug which will cause test fail with jdk fastdebug build. Change has been verified locally, test-fix only, no risk.
@sendaoYan 8353657: The approval request was already up to date.