jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8352716: (tz) Update Timezone Data to 2025b

Open satyenme opened this issue 7 months ago • 7 comments
trafficstars

Backport of tzdata2025b. Nearly clean, but contains zone.tab file, which was removed by JDK-8166983.

Reverted change to aliases.txt and displaynames.txt when running make in jdk/test/java/util/TimeZone/tools/share to avoid the jdk/test/java/util/TimeZone/Bug6329116.java test failing, just as was done previously for 2024b.

Passed tier1 tests, as well as jdk/test/java/util/TimeZone, jdk/test/java/time, jdk/test/sun/util/resources, jdk/test/sun/text/resources, and jdk/test/sun/util/calendar tests locally. Passing GHA sanity tests (other than known failures).


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8352716 needs maintainer approval

Issue

  • JDK-8352716: (tz) Update Timezone Data to 2025b (Enhancement - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/644/head:pull/644
$ git checkout pull/644

Update a local copy of the PR:
$ git checkout pull/644
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 644

View PR using the GUI difftool:
$ git pr show -t 644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/644.diff

Using Webrev

Link to Webrev Comment

satyenme avatar Mar 31 '25 22:03 satyenme

:wave: Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 31 '25 22:03 bridgekeeper[bot]

@satyenme This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8352716: (tz) Update Timezone Data to 2025b

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 1304a9b0c703c19a17a68da22af6e534f6e320a5: 8278472: Invalid value set to CANDIDATEFORM structure
  • 176d674745b33f86d810732c13465279a5aadeda: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • 656b3cfda2d349e8198ee4058d17352887d948f8: 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names
  • ... and 17 more: https://git.openjdk.org/jdk8u-dev/compare/af6e57b7191ecc23d55658a97228c7311a2c2268...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Mar 31 '25 22:03 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Mar 31 '25 22:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 31 '25 22:03 mlbridge[bot]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Mar 31 '25 22:03 openjdk[bot]

/approval request for backport of 2025b tzdata. Nearly clean, but needed to re-add zone.tab file, which was removed by JDK-8166983.

Risk: Medium to Low. Tier 1 and relevant tz tests passing, as well as GHA sanity check tests. Backporting tzdata changes is a common enough procedure that, after review, we can be reasonably confident will work as intended.

Testing:

  • GHA Sanity Checks (with a couple known, unrelated failures)
  • Tier 1 tests locally
  • jdk/test/java/util/TimeZone, jdk/test/java/time, jdk/test/sun/util/resources, jdk/test/sun/text/resources, and jdk/test/sun/util/calendar tests locally

satyenme avatar Apr 01 '25 16:04 satyenme

@satyenme 8352716: The approval request has been created successfully.

openjdk[bot] avatar Apr 01 '25 16:04 openjdk[bot]

Update: this change has been integrated into Oracle JDK 8u461

satyenme avatar Apr 22 '25 16:04 satyenme

/integrate

satyenme avatar May 19 '25 20:05 satyenme

@satyenme Your change (at version b7c33d5fa4f265b5a182780b3de72bad7e615d97) is now ready to be sponsored by a Committer.

openjdk[bot] avatar May 19 '25 20:05 openjdk[bot]

/sponsor

phohensee avatar May 20 '25 17:05 phohensee

Going to push as commit 6fd5ba5f62bfffc8b127aec0f56f7b1987dee46d. Since your change was applied there have been 23 commits pushed to the master branch:

  • 3e4321d11e557887378d42258be7130878b9ac5e: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
  • 55e7ecc26b80b694b378c4d2d64a5e2da815bc48: 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows
  • 73dca05a92e7751006622c33335540300bb2bb4d: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken
  • ... and 20 more: https://git.openjdk.org/jdk8u-dev/compare/af6e57b7191ecc23d55658a97228c7311a2c2268...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 20 '25 17:05 openjdk[bot]

@phohensee @satyenme Pushed as commit 6fd5ba5f62bfffc8b127aec0f56f7b1987dee46d.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 20 '25 17:05 openjdk[bot]