jdk8u-dev
jdk8u-dev copied to clipboard
8026976: ECParameters, Point does not match field size
Hi all,
This is a backport of JDK-8026976: ECParameters, Point does not match field size
Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u.
Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing
Thanks.
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8026976 needs maintainer approval
Issue
- JDK-8026976: ECParameters, Point does not match field size (Bug - P4 - Requested)
Reviewers
- Paul Hohensee (@phohensee - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/643/head:pull/643
$ git checkout pull/643
Update a local copy of the PR:
$ git checkout pull/643
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/643/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 643
View PR using the GUI difftool:
$ git pr show -t 643
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/643.diff
Using Webrev
:wave: Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
@kurashige23 This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8026976: ECParameters, Point does not match field size
Reviewed-by: phh, mbalao
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @martinuy) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
This backport pull request has now been updated with issue from the original commit.
⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
I think the GHA error is a certificate issue and not related to this PR.
/approval request Except for the fix in the Problemlist, original patch apply cleanly to 8u. The risk is low because the fix to the source is only for P11ECKeyFactory.java and it is just addition of switching by UseEcX963Encoding. pkcs11 tests on RHEL9 and GHA tests pass.
@kurashige23 8026976: The approval request has been created successfully.
@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@jerboaa
I recognize that JDK-8026976 requires a maintainer approval. You have given me a maintainer approval in https://github.com/openjdk/jdk11u-dev/pull/2958. I'm sorry to bother you, but could you approve JDK-8026976?
Thanks.
@franferrax @martinuy Could somebody of you please review this, too? Thanks!
Thank you for your review.
/integrate
@kurashige23 Your change (at version d36707465d079d85dfe254187efe0778e05cbb06) is now ready to be sponsored by a Committer.
/sponsor
Going to push as commit 5e59411bd3760a4c54bd52d301d882e4a9f5aab4.
@jerboaa @kurashige23 Pushed as commit 5e59411bd3760a4c54bd52d301d882e4a9f5aab4.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.