8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

[kurashige23]

trafficstars

Hi all,

This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

Original patch doesn't apply cleanly to 8u because JDK-8056911 isn't backported to 8u.

Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix. So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot.

Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2

Thanks.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [ ] JDK-8160767 needs maintainer approval
• [x] Commit message must refer to an issue

Issue

• JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/637/head:pull/637
$ git checkout pull/637

Update a local copy of the PR:
$ git checkout pull/637
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 637

View PR using the GUI difftool:
$ git pr show -t 637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/637.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 7fea4115570935878cc8b13704c6af0ad63a3a75: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly"
• 41e6bf7d1f6a0b576c46c1f00e2c4cbc89a48a96: 8366112: [8u] GHA: Fix broken installation of Windows SDK
• cc30193d1bd7ab9217f2c7b6d08de612c558cd96: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (4cf30b12)
• 01: Full - Incremental (34784cea)
• 00: Full (f5c72762)

[kurashige23]

This is a clean backport as only path changes.

/clean

[openjdk[bot]]

@kurashige23 The /clean pull request command is not enabled for this repository

[bridgekeeper[bot]]

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@kurashige23 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[kurashige23]

/open

[openjdk[bot]]

@kurashige23 This pull request is now open

[kurashige23]

Could anyone review this PR?

[bridgekeeper[bot]]

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[kurashige23]

Hi, @phohensee

Sorry for sudden mention. I have dealt with this comment, but I haven't been able to get response for about 5 months. If possible, could you review this PR instead? Thanks.

I think GHA error is not related to this PR fix.

[openjdk[bot]]

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[kurashige23]

Thank you for your review.

/approval request Backporting this patch resolves failure of MaximizedToIconified.java. Test-only fix, low risk. Original patch does not apply cleanly because JDK-8056911 is not ported to jdk8. Backporting JDK-8056911 was rejected in the past because changing the behavior of public methods is undesirable. So I modified the test to use ExtendedRobot directly instead of applying JDK-8056911. MaximizedToIconified.java passes on RHEL9.4.

[openjdk[bot]]

@kurashige23 8160767: The approval request has been created successfully.

[kurashige23]

/integrate

[openjdk[bot]]

@kurashige23 Your change (at version 4cf30b127141c1c537b87542e69bd2333cf71777) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk[bot]]

Going to push as commit bb19ce35ff190c77d0dc030286bfbec0473b6b81. Since your change was applied there have been 5 commits pushed to the master branch:

• 1d7e10189fecbe673f5873f298a6d825bfbc1888: 8041924: [TESTBUG] sun/net/www/http/ChunkedOutputStream/checkError.java fails on some systems
• f362183b50937f7e7ab34427f2ab2c8fab895e20: 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed
• 7fea4115570935878cc8b13704c6af0ad63a3a75: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly"
• ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/2821dcef9484b0a551d1c6b4ab014892ab07b55a...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@phohensee @kurashige23 Pushed as commit bb19ce35ff190c77d0dc030286bfbec0473b6b81.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.