8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb

[mrserb]

The TZDATA path has been updated to work with jdk8u-dev layout.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8351439 needs maintainer approval

Issue

• JDK-8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb (Bug - P4 - Requested)

Reviewers

• Dmitry Cherepanov (@dimitryc - Reviewer) Review applies to e3e0d654
• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/634/head:pull/634
$ git checkout pull/634

Update a local copy of the PR:
$ git checkout pull/634
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/634/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 634

View PR using the GUI difftool:
$ git pr show -t 634

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/634.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb

Reviewed-by: sgehwolf, dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge[bot]]

Webrevs

• 02: Full - Incremental (92943316)
• 01: Full - Incremental (fff62df3)
• 00: Full (e3e0d654)

[openjdk[bot]]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mrserb]

/approval request. Fix for a typo to simplify updating the TimeZone test during the tzdata integration process.

[openjdk[bot]]

@mrserb 8351439: The approval request has been created successfully.

[bridgekeeper[bot]]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

/integrate

[openjdk[bot]]

Going to push as commit 535e6215cad8f52a36002ed931273cded219d99f.

[openjdk[bot]]

@mrserb Pushed as commit 535e6215cad8f52a36002ed931273cded219d99f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[gnu-andrew]

What makes you think this is 8u only? The path wasn't changed until JDK-8257733 in OpenJDK 19 and the file in question was backported from JDK-8028265 in OpenJDK 20.

Do you actually make use of this Makefile? Given we usually backport the generated test files in question from trunk where the java.base path is correct, I can see why this has been missed for the past two and a half years.

[mrserb]

Do you actually make use of this Makefile? Given we usually backport the generated test files in question from trunk where the java.base path is correct, I can see why this has been missed for the past two and a half years.

Yes, you are right - starting with JDK 11 most of the time it's just about applying changes from trunk, so this file does not play a significant role. However, JDK 8 uses a different format, which requires manual handling and as part of that process we also regenerate the test data(just in case), which has helped uncover some missed changes recently.(this bug was fixed in our src looong time ago).