jdk8u-dev
jdk8u-dev copied to clipboard
8339803: Acknowledge case insensitive unambiguous keywords in tzdata files
Improves parsing of keywords in tzdata rules
- The patch from 11u doesn't apply cleanly due to JDK-8042369 missing in 8u. I backported new version of
parseYearmethod (https://hg.openjdk.org/jdk9/jdk9/jdk/rev/6c26f18d9bc0#l8.347) with minor adaption to 8u codebase and then replaced uses ofequals()withregionMatches() - Minor conflict in copyright year in RuleRec.java, applied manually
Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8339803 needs maintainer approval
Issue
- JDK-8339803: Acknowledge case insensitive unambiguous keywords in tzdata files (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/632/head:pull/632
$ git checkout pull/632
Update a local copy of the PR:
$ git checkout pull/632
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/632/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 632
View PR using the GUI difftool:
$ git pr show -t 632
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/632.diff
Using Webrev
:wave: Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
This backport pull request has now been updated with issue from the original commit.
@dimitryc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@dimitryc This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.