jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names

Open alexeybakhtin opened this issue 9 months ago • 6 comments
trafficstars

I backport this for parity with Oracle 8u351 Almost clean backport except for DNSName.java: small manual merge in the constructor caused by the absence of "JDK-8215281: Use String.isEmpty() when applicable in java.base"

All sun/security/x509 and sun/security/tools/keytool JTREG tests passed


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8186143 needs maintainer approval

Issue

  • JDK-8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names (Bug - P2 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/629/head:pull/629
$ git checkout pull/629

Update a local copy of the PR:
$ git checkout pull/629
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/629/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 629

View PR using the GUI difftool:
$ git pr show -t 629

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/629.diff

Using Webrev

Link to Webrev Comment

alexeybakhtin avatar Feb 25 '25 20:02 alexeybakhtin

:wave: Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 25 '25 20:02 bridgekeeper[bot]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • eca7a305e1df50eaf459dcf43448d0ef911da5cc: 8071996: split_if accesses NULL region of ConstraintCast
  • 5e59411bd3760a4c54bd52d301d882e4a9f5aab4: 8026976: ECParameters, Point does not match field size
  • 55273f7267b95cf38743bb32ea61a513fbafb06e: 8293107: GHA: Bump to Ubuntu 22.04
  • ... and 31 more: https://git.openjdk.org/jdk8u-dev/compare/8eccf896169b568c70a188d085b0673d225e1f8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Feb 25 '25 20:02 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Feb 25 '25 20:02 openjdk[bot]

Webrevs

mlbridge[bot] avatar Feb 25 '25 20:02 mlbridge[bot]

Please review. CI failures in CAInterop test are not related to the proposed changes

alexeybakhtin avatar Mar 13 '25 18:03 alexeybakhtin

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Mar 26 '25 15:03 openjdk[bot]

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 23 '25 17:04 bridgekeeper[bot]

/integrate

alexeybakhtin avatar May 16 '25 18:05 alexeybakhtin

Going to push as commit 656b3cfda2d349e8198ee4058d17352887d948f8. Since your change was applied there have been 34 commits pushed to the master branch:

  • eca7a305e1df50eaf459dcf43448d0ef911da5cc: 8071996: split_if accesses NULL region of ConstraintCast
  • 5e59411bd3760a4c54bd52d301d882e4a9f5aab4: 8026976: ECParameters, Point does not match field size
  • 55273f7267b95cf38743bb32ea61a513fbafb06e: 8293107: GHA: Bump to Ubuntu 22.04
  • ... and 31 more: https://git.openjdk.org/jdk8u-dev/compare/8eccf896169b568c70a188d085b0673d225e1f8f...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar May 16 '25 18:05 openjdk[bot]

@alexeybakhtin Pushed as commit 656b3cfda2d349e8198ee4058d17352887d948f8.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 16 '25 18:05 openjdk[bot]