jdk8u-dev
jdk8u-dev copied to clipboard
openjdk
8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms
Hi all,
We observerd the test sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java intermittent fails on jdk8u-dev. The failure phenomenon samt to JDK-8228658. So I want to backport this PR from jdk11u-dev to jdk8u-dev.
Only the copyright year backported not cleanly, the copyright year modified by JDK-6719955 and JDK-6943119 in jdk8u-dev. Other parts are backport cleanly.
The change has been verified locally, make the test more robustness, test fix only, no risk.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [ ] JDK-8228658 needs maintainer approval
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
Issue
- JDK-8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/578/head:pull/578
$ git checkout pull/578
Update a local copy of the PR:
$ git checkout pull/578
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/578/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 578
View PR using the GUI difftool:
$ git pr show -t 578
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/578.diff
Using Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sendaoYan This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms
Reviewed-by: phh
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 114 new commits pushed to the master branch:
- 51b6307937d9584f8690e4916444e479eeafff28: 8339414: Fix JDK-8202369 incorrect backport for 8u
- 4f9234206475401978f3cc33286cbc41f2c8bc1b: 8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324
- bf1754263cffbe07fc1e84d38b839177b173cc16: 8358328: Bump update version of OpenJDK: 8u472
- ... and 111 more: https://git.openjdk.org/jdk8u-dev/compare/89697c3c19f1276e92c6955600730b8d3353c4ea...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
The GHA report several failures, all the failures unreleated to this PR.
- linux x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR.
- linux x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR.
- linux x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR.
- windows x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR.
- windows x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR.
- macos x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR.
- macos x64 hotspot/tier1
compiler/unsafe/OpaqueAccesses.javatest fails, which has been recorded by JDK-8337185, it's unreleated to this PR.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request Backport from jdk11u-dev to make the test more robustness, test fix only, no risk. The change has been verified locally.
@sendaoYan Your change (at version c46f1d61019e5642f14926dbf77290d3b4f0a6a7) is now ready to be sponsored by a Committer.
Going to push as commit 5a6e681faecd7ea2df0a278f58075f6e38e62cce.
Since your change was applied there have been 115 commits pushed to the master branch:
- f08dd7fb6abfb94d72625859c1357ad094cd4d2b: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
- 51b6307937d9584f8690e4916444e479eeafff28: 8339414: Fix JDK-8202369 incorrect backport for 8u
- 4f9234206475401978f3cc33286cbc41f2c8bc1b: 8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324
- ... and 112 more: https://git.openjdk.org/jdk8u-dev/compare/89697c3c19f1276e92c6955600730b8d3353c4ea...master
Your commit was automatically rebased without conflicts.