jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode

Open mrserb opened this issue 1 year ago • 6 comments

Hi all,

This pull request contains a backport of commit eb790603 from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 11 Aug 2015 and was reviewed by Joe Darcy.

Thanks!


Progress

  • [ ] JDK-8133287 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/570/head:pull/570
$ git checkout pull/570

Update a local copy of the PR:
$ git checkout pull/570
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/570/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 570

View PR using the GUI difftool:
$ git pr show -t 570

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/570.diff

Webrev

Link to Webrev Comment

mrserb avatar Aug 28 '24 23:08 mrserb

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 28 '24 23:08 bridgekeeper[bot]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode

Add @build tag containing ParallelProbes and SimpleFileTypeDetector and reinstate othervm mode.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Aug 28 '24 23:08 openjdk[bot]

This backport pull request has now been updated with issue and summary from the original commit.

openjdk[bot] avatar Aug 28 '24 23:08 openjdk[bot]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Aug 29 '24 02:08 openjdk[bot]

Webrevs

mlbridge[bot] avatar Aug 29 '24 02:08 mlbridge[bot]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 26 '24 06:09 bridgekeeper[bot]

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Oct 24 '24 11:10 bridgekeeper[bot]

/open

mrserb avatar Oct 24 '24 23:10 mrserb

@mrserb This pull request is now open

openjdk[bot] avatar Oct 24 '24 23:10 openjdk[bot]

/integrate

mrserb avatar Oct 29 '24 23:10 mrserb

Going to push as commit 41f479c4801ebbf96e1d6bebe1d26d3a5f7a4dc1. Since your change was applied there have been 15 commits pushed to the master branch:

  • 7e1ea515911827915c27c6568585c6c7906a74d9: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method
  • 31b88042fba46e87fba83e8bfd43ae0ecb5a9afd: Merge
  • 618917eb093243de2c5d7e83d4688bfe9ad04985: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 1c1afe3188df5621b5523ae9a06ad39c8a253589: 8341057: Add 2 SSL.com TLS roots
  • e976b99775c95013431b7119a61dac3409b3bf16: 8335713: Enhance vectorization analysis
  • c5508ab0a6f565bb774ccf786f3290e59f5ab116: 8332644: Improve graph optimizations
  • da6b2652f5afb1270140d1bc680f2ef3d8f9c51a: 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property
  • 3b077b8a7cf07e2c06064efbddbc5488cdf710bb: 8331446: Improve deserialization support
  • 165022181994b20d50e8631f88182f11d95e1ccb: 8328726: Better Kerberos support
  • 0405894d5183be14e2563617446e90192eced09d: 8328544: Improve handling of vectorization
  • ... and 5 more: https://git.openjdk.org/jdk8u-dev/compare/b6616d688fd8acd9cf141ee82f53de7ac90a262d...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 29 '24 23:10 openjdk[bot]

@mrserb Pushed as commit 41f479c4801ebbf96e1d6bebe1d26d3a5f7a4dc1.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 29 '24 23:10 openjdk[bot]