jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8297088: Update LCMS to 2.14

Open mrserb opened this issue 1 year ago • 6 comments
trafficstars

...placeholder...


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8273135 needs maintainer approval
  • [ ] JDK-8297088 needs maintainer approval

Issues

  • JDK-8297088: Update LCMS to 2.14 (Bug - P3)
  • JDK-8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/569/head:pull/569
$ git checkout pull/569

Update a local copy of the PR:
$ git checkout pull/569
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 569

View PR using the GUI difftool:
$ git pr show -t 569

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/569.diff

mrserb avatar Aug 28 '24 04:08 mrserb

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Aug 28 '24 04:08 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Aug 28 '24 04:08 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Aug 28 '24 04:08 openjdk[bot]

/issue add 8273135

mrserb avatar Aug 28 '24 04:08 mrserb

@mrserb Adding additional issue to issue list: 8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7.

openjdk[bot] avatar Aug 28 '24 04:08 openjdk[bot]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout lcms2.14
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk-notifier[bot] avatar Sep 09 '24 21:09 openjdk-notifier[bot]

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '24 03:10 bridgekeeper[bot]

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '24 09:10 bridgekeeper[bot]

@mrserb This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '24 15:10 bridgekeeper[bot]

@mrserb This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Dec 26 '24 16:12 bridgekeeper[bot]