jdk8u-dev
jdk8u-dev copied to clipboard
openjdk
8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
Hi all,
This PR contains two backports JDK-8266881 and JDK-8227651 from jdk11u-dev.
We observed javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails.
The change in test/jdk/ProblemList.txt was not needed deal with in jdk8u-dev, all other files are backported cleanly.
Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk.
Additional testing:
- [x] full jtreg tests on linux x64
- [x] full jtreg tests on linux aarch64
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8266881 needs maintainer approval
- [ ] JDK-8212096 needs maintainer approval
- [ ] JDK-8227651 needs maintainer approval
Issues
- JDK-8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java (Bug - P4 - Requested)
- JDK-8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch (Bug - P3 - Requested)
- JDK-8227651: Tests fail with SSLProtocolException: Input record too big (Bug - P3 - Requested)
Reviewers
- Paul Hohensee (@phohensee - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/567/head:pull/567
$ git checkout pull/567
Update a local copy of the PR:
$ git checkout pull/567
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/567/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 567
View PR using the GUI difftool:
$ git pr show -t 567
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/567.diff
Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@sendaoYan This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch
8227651: Tests fail with SSLProtocolException: Input record too big
Reviewed-by: phh
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 55 new commits pushed to the master branch:
- 492acd3ac4b4fbd4bfe90a00d8f5cd48ffbe372c: 8265019: Update tests for additional TestNG test permissions
- 3683a81d332c26737bef1f0b59b4d68ae4242c09: Merge
- 129290d2ffe3f77ad574bfad8b1ab44f5f3b8fbe: 8339180: Enhanced Building of Processes: Follow-on Issue
- c2f7e61272996631585153c70d784e7690763f01: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
- 2d042cfa40532e28b697c5a53bd282c2319d2f02: 8336564: Enhance mask blit functionality redux
- 1a447c78dd71929d50f91698204a7c66e41acfb9: 8335428: Enhanced Building of Processes
- 1a6e3a5ea32d5c671cb46a590046f16426089921: 8342822: jdk8u432-b06 does not compile on AIX
- 5a4b44089f3f95b92620ef3a7b49f2390b70afaa: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
- d407d631f80559a5fed251d9fef2cef64ddf7936: 8345504: Bump update version of OpenJDK: 8u452
- 2931b1d250dbf820b2094b67f5ae19d223e7c887: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F
- ... and 45 more: https://git.openjdk.org/jdk8u-dev/compare/89697c3c19f1276e92c6955600730b8d3353c4ea...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@sendaoYan This issue is referenced in the PR title - it will now be updated.
@sendaoYan
Adding additional issue to issue list: 8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch.
@sendaoYan
Adding additional issue to issue list: 8227651: Tests fail with SSLProtocolException: Input record too big.
/approval JDK-8266881 request Prefixed backport of JDK-8212096, add debug information, test-fix only, no risk.
All the GHA test failures are unreleated to this PR
- Linux x64 (jdk/tier1) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526
- Linux x86 (jdk/tier1) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526
- Windows x64 (jdk/tier1) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526
- Windows x86 (jdk/tier1) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526
- MacOS x64 (jdk/tier1) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526
- macOS x64 (hotspot/tier1) report
compiler/unsafe/OpaqueAccesses.javais a known failure, which has been recorded by JDK-8337185
/approval JDK-8212096 request Backport from jdk11u-dev to jdk8u-dev, to fix the intermittent failure, test fix only, the change has been verified, no risk.
/approval JDK-8227651 request Backport from jdk11u-dev to jdk8u-dev, to fix the intermittent failure, test fix only, the change has been verified, no risk.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval JDK-8266881 request Prefixed backport of JDK-8212096, add debug information, test-fix only, no risk.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.