jdk8u-dev
jdk8u-dev copied to clipboard
openjdk
8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
TestNoEagerReclaimOfHumongousRegions.java is placed (as the only test) in gc_implementation/g1 directory instead of gc/g1, where similar tests are placed. As a result test is not part of any test group and is currently not executed as part of tier1.
This seems like mistake in JDK-8139424 backport (orig, 8). Hotspot code uses dir named gc_implementation instead of gc on 8, but this is not the case for tests.
This change moves TestNoEagerReclaimOfHumongousRegions.java hotspot test from gc_implementation/g1 -> gc/g1.
Testing: tier1: OK (After this change, test newly executes as part of tier1 and passes on all systems. Failures of other tests are unrelated.)
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8337110 needs maintainer approval
Issue
- JDK-8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory (Bug - P4 - Requested)
Reviewers
- Paul Hohensee (@phohensee - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/551/head:pull/551
$ git checkout pull/551
Update a local copy of the PR:
$ git checkout pull/551
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/551/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 551
View PR using the GUI difftool:
$ git pr show -t 551
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/551.diff
Webrev
:wave: Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@zzambers This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
Reviewed-by: phh
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 25 new commits pushed to the master branch:
- edbdf0538df3fe764ea6a109c3e07cb145dbfe48: 8336928: GHA: Bundle artifacts removal broken
- 1ca84ad59a4db33ab43cebc7d78ee99f87455be1: 8305400: ISO 4217 Amendment 175 Update
- ea76f37ddb113b84f5421d64e687e1b6b7a13ea6: 8338144: [8u] Remove duplicate license files
- fb0a658dd5dc417fa4ce74b17d10c507ed6bc66f: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
- 4538bba37c61982e3122dbf83fa2ea5c70434641: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
- 4106121e0ae42d644e45c6eab9037874110ed670: 8281096: Flags introduced by configure script are not passed to ADLC build
- b4fc8e711c5953823e687f8cc133aac5e8fdd577: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
- 09bab6e4c31531975ab6461832d4618dc9759ca9: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
- d4adbe339c3dd09a7f431da2c909b03560c6579e: 8152207: Perform array bound checks while getting a length of bytecode instructions
- 047b08a891d837efb925448b6334679f772ef0e5: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
- ... and 15 more: https://git.openjdk.org/jdk8u-dev/compare/765bd89b6c3dd12f9248d8626884103f58cbaa5a...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.
⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request Fixes location of TestNoEagerReclaimOfHumongousRegions.java, affects test only, GHA testing OK
Going to push as commit 7d36fed8e01c6ee0a1b301a379df5dae8afa960d.
Since your change was applied there have been 39 commits pushed to the master branch:
- 49425166c201e73dd954bd033ea6e33f4a9811b3: 8278794: Infinite loop in DeflaterOutputStream.finish()
- 89697c3c19f1276e92c6955600730b8d3353c4ea: 8334653: ISO 4217 Amendment 177 Update
- 9a426ad460815f2637d53df37b27b68e64d5b75b: 8318951: Additional negative value check in JPEG decoding
- aa443466bbe5f8326ab595ef9f4a2fa9919250e9: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
- fc33f51c24d21e30a73ce3a70ba961651b483672: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
- 8867d017b18ad7cd8842b9324c5c031a44a58064: 8193682: Infinite loop in ZipOutputStream.close()
- 5c7f201af69a500b06a345f84a5b1ce550b605b2: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
- 933c78ebd5be5aedc2181b95917933dffe7e279c: 8309138: Fix container tests for jdks with symlinked conf dir
- 4fe22e82ebd3640c7999e094903874c9ac7f2391: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
- 855480b9336976cfdeea6ff5f57a712e4119e61a: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
- ... and 29 more: https://git.openjdk.org/jdk8u-dev/compare/765bd89b6c3dd12f9248d8626884103f58cbaa5a...master
Your commit was automatically rebased without conflicts.
@zzambers Pushed as commit 7d36fed8e01c6ee0a1b301a379df5dae8afa960d.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.