8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415

[sendaoYan]

trafficstars

Hi all, The testcase sun/management/jmxremote/startstop/JMXStartStopTest.java compile error after JDK-8334415. This PR fix the testcase bug, the change has been verified, no risk.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8335851 needs maintainer approval

Issue

• JDK-8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/541/head:pull/541
$ git checkout pull/541

Update a local copy of the PR:
$ git checkout pull/541
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 541

View PR using the GUI difftool:
$ git pr show -t 541

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/541.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 4106121e0ae42d644e45c6eab9037874110ed670: 8281096: Flags introduced by configure script are not passed to ADLC build
• b4fc8e711c5953823e687f8cc133aac5e8fdd577: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
• 09bab6e4c31531975ab6461832d4618dc9759ca9: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
• d4adbe339c3dd09a7f431da2c909b03560c6579e: 8152207: Perform array bound checks while getting a length of bytecode instructions
• 047b08a891d837efb925448b6334679f772ef0e5: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• 0e7148dbfab4b01bdcb615eb2e8d217a47d6874e: Merge
• 18b3ca58d72881d3b6a89c6f299e26635fd149c4: 8325600: Better symbol storage
• dfbb2cfbc4887184487206224f0503a7ccd2b3f6: 8324559: Improve 2D image handling
• bffe2842ea81ed73668e72bc1009f21ac4c2023f: 8323231: Improve array management
• 172214bbc8e1a8c9f2ff5e87151afb38d9092902: 8323390: Enhance mask blit functionality
• ... and 15 more: https://git.openjdk.org/jdk8u-dev/compare/c8eb027b59dbb12150a1edd926b14fc2f6753bbd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge[bot]]

Webrevs

• 00: Full (bca02cc7)

[sendaoYan]

The GHA report several failures.

1. Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3

2. Linux x86 gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java report crash CompactibleFreeListSpace::block_size(HeapWord const*), which has been recorded by JDK-8303159, it's unrelated to this PR.
3. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

[sendaoYan]

/approval request Fix testcase bug introduced by JDK-8334415. The change has been verified, no risk.

[openjdk[bot]]

@sendaoYan 8335851: The approval request has been created successfully.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Fix test bugs of testcase, no risk. Can anyone take look this PR.

[sendaoYan]

Thanks all for the approved and review. /integrate

[openjdk[bot]]

@sendaoYan Your change (at version bca02cc788967797c7eefeacfa6b10757068d162) is now ready to be sponsored by a Committer.

[mrserb]

/sponsor

[openjdk[bot]]

Going to push as commit 4538bba37c61982e3122dbf83fa2ea5c70434641. Since your change was applied there have been 25 commits pushed to the master branch:

• 4106121e0ae42d644e45c6eab9037874110ed670: 8281096: Flags introduced by configure script are not passed to ADLC build
• b4fc8e711c5953823e687f8cc133aac5e8fdd577: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
• 09bab6e4c31531975ab6461832d4618dc9759ca9: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
• d4adbe339c3dd09a7f431da2c909b03560c6579e: 8152207: Perform array bound checks while getting a length of bytecode instructions
• 047b08a891d837efb925448b6334679f772ef0e5: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• 0e7148dbfab4b01bdcb615eb2e8d217a47d6874e: Merge
• 18b3ca58d72881d3b6a89c6f299e26635fd149c4: 8325600: Better symbol storage
• dfbb2cfbc4887184487206224f0503a7ccd2b3f6: 8324559: Improve 2D image handling
• bffe2842ea81ed73668e72bc1009f21ac4c2023f: 8323231: Improve array management
• 172214bbc8e1a8c9f2ff5e87151afb38d9092902: 8323390: Enhance mask blit functionality
• ... and 15 more: https://git.openjdk.org/jdk8u-dev/compare/c8eb027b59dbb12150a1edd926b14fc2f6753bbd...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@mrserb @sendaoYan Pushed as commit 4538bba37c61982e3122dbf83fa2ea5c70434641.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.