jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir

Open sendaoYan opened this issue 1 year ago • 7 comments
trafficstars

Hi all, Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. Only change the testcase lib file, the risk is low. This is similar to JDK-8309138, but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory.

Additional testing:

  • [x] hotspot/test/runtime/containers/docker

docker-tests.log


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8335845 needs maintainer approval

Issue

  • JDK-8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/539/head:pull/539
$ git checkout pull/539

Update a local copy of the PR:
$ git checkout pull/539
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 539

View PR using the GUI difftool:
$ git pr show -t 539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/539.diff

Webrev

Link to Webrev Comment

sendaoYan avatar Jul 08 '24 07:07 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 08 '24 07:07 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Jul 08 '24 07:07 openjdk[bot]

/approval request Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. Only change the testcase lib file, the risk is low. The changed has been verified.

sendaoYan avatar Jul 08 '24 07:07 sendaoYan

@sendaoYan 8335845: The approval request has been created successfully.

openjdk[bot] avatar Jul 08 '24 07:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 08 '24 07:07 mlbridge[bot]

The GHA report several failures.

  1. Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3
  1. Linux x86 gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java report crash CompactibleFreeListSpace::block_size(HeapWord const*), which has been recorded by JDK-8303159, it's unrelated to this PR.
  2. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

sendaoYan avatar Jul 08 '24 08:07 sendaoYan

Thanks for the review.

sendaoYan avatar Jul 27 '24 01:07 sendaoYan

Include by https://github.com/openjdk/jdk8u-dev/pull/538

sendaoYan avatar Aug 20 '24 16:08 sendaoYan