jdk8u-dev
jdk8u-dev copied to clipboard
8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir
Hi all, Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. Only change the testcase lib file, the risk is low. This is similar to JDK-8309138, but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory.
Additional testing:
- [x] hotspot/test/runtime/containers/docker
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8335845 needs maintainer approval
Issue
- JDK-8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir (Bug - P4 - Requested)
Reviewers
- Paul Hohensee (@phohensee - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/539/head:pull/539
$ git checkout pull/539
Update a local copy of the PR:
$ git checkout pull/539
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/539/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 539
View PR using the GUI difftool:
$ git pr show -t 539
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/539.diff
Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
/approval request Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. Only change the testcase lib file, the risk is low. The changed has been verified.
@sendaoYan 8335845: The approval request has been created successfully.
The GHA report several failures.
- Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3
- Linux x86
gc/concurrentMarkSweep/SystemGCOnForegroundCollector.javareport crashCompactibleFreeListSpace::block_size(HeapWord const*), which has been recorded by JDK-8303159, it's unrelated to this PR. - MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.
Thanks for the review.
Include by https://github.com/openjdk/jdk8u-dev/pull/538