jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java

Open mrserb opened this issue 1 year ago • 7 comments
trafficstars

Hi all,

This pull request contains a backport of commit 6678b01c from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 29 Mar 2021 and was reviewed by Alexander Zuev, Tejpal Rebari and Pankaj Bansal.

Thanks!


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8264328 needs maintainer approval

Issue

  • JDK-8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/535/head:pull/535
$ git checkout pull/535

Update a local copy of the PR:
$ git checkout pull/535
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 535

View PR using the GUI difftool:
$ git pr show -t 535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/535.diff

Webrev

Link to Webrev Comment

mrserb avatar Jul 06 '24 14:07 mrserb

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 06 '24 14:07 bridgekeeper[bot]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • edbdf0538df3fe764ea6a109c3e07cb145dbfe48: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad59a4db33ab43cebc7d78ee99f87455be1: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37ddb113b84f5421d64e687e1b6b7a13ea6: 8338144: [8u] Remove duplicate license files
  • fb0a658dd5dc417fa4ce74b17d10c507ed6bc66f: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba37c61982e3122dbf83fa2ea5c70434641: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121e0ae42d644e45c6eab9037874110ed670: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e711c5953823e687f8cc133aac5e8fdd577: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • 09bab6e4c31531975ab6461832d4618dc9759ca9: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
  • d4adbe339c3dd09a7f431da2c909b03560c6579e: 8152207: Perform array bound checks while getting a length of bytecode instructions
  • 047b08a891d837efb925448b6334679f772ef0e5: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • ... and 20 more: https://git.openjdk.org/jdk8u-dev/compare/c8eb027b59dbb12150a1edd926b14fc2f6753bbd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jul 06 '24 14:07 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jul 06 '24 14:07 openjdk[bot]

/clean the patch is identical to openjdk/jdk

mrserb avatar Jul 06 '24 23:07 mrserb

@mrserb This backport pull request is now marked as clean

openjdk[bot] avatar Jul 06 '24 23:07 openjdk[bot]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jul 06 '24 23:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 06 '24 23:07 mlbridge[bot]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 04 '24 01:08 bridgekeeper[bot]

keep open

mrserb avatar Aug 12 '24 17:08 mrserb

/integrate

mrserb avatar Aug 21 '24 00:08 mrserb

Going to push as commit 8b28c35f2efe5f4d6bd2f4e36720ca6a529836dd. Since your change was applied there have been 32 commits pushed to the master branch:

  • 2afd9188fa17d748dca15bcdc1f39bdb1c6dfca9: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 439e910420ab9e1ca7c4645bb20634bc7cdbbe57: 8321480: ISO 4217 Amendment 176 Update
  • edbdf0538df3fe764ea6a109c3e07cb145dbfe48: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad59a4db33ab43cebc7d78ee99f87455be1: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37ddb113b84f5421d64e687e1b6b7a13ea6: 8338144: [8u] Remove duplicate license files
  • fb0a658dd5dc417fa4ce74b17d10c507ed6bc66f: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba37c61982e3122dbf83fa2ea5c70434641: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121e0ae42d644e45c6eab9037874110ed670: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e711c5953823e687f8cc133aac5e8fdd577: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • 09bab6e4c31531975ab6461832d4618dc9759ca9: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
  • ... and 22 more: https://git.openjdk.org/jdk8u-dev/compare/c8eb027b59dbb12150a1edd926b14fc2f6753bbd...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 21 '24 00:08 openjdk[bot]

@mrserb Pushed as commit 8b28c35f2efe5f4d6bd2f4e36720ca6a529836dd.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 21 '24 00:08 openjdk[bot]