jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8315731: Open source several Swing Text related tests

Open mrserb opened this issue 1 year ago • 9 comments
trafficstars

Hi all,

This pull request contains a backport of commit 0dc17ca0 from the openjdk/jdk11u-dev repository.

The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8315731 needs maintainer approval

Issue

  • JDK-8315731: Open source several Swing Text related tests (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/516/head:pull/516
$ git checkout pull/516

Update a local copy of the PR:
$ git checkout pull/516
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/516/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 516

View PR using the GUI difftool:
$ git pr show -t 516

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/516.diff

Webrev

Link to Webrev Comment

mrserb avatar Jun 10 '24 02:06 mrserb

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 10 '24 02:06 bridgekeeper[bot]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315731: Open source several Swing Text related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jun 10 '24 02:06 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jun 10 '24 02:06 openjdk[bot]

/clean the fix is identical to openjdk/jdk11u-dev

mrserb avatar Jun 10 '24 02:06 mrserb

@mrserb This backport pull request is now marked as clean

openjdk[bot] avatar Jun 10 '24 02:06 openjdk[bot]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jun 10 '24 02:06 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jun 10 '24 02:06 mlbridge[bot]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 08 '24 06:07 bridgekeeper[bot]

keep open

mrserb avatar Jul 11 '24 00:07 mrserb

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 08 '24 03:08 bridgekeeper[bot]

keep open

mrserb avatar Aug 12 '24 17:08 mrserb

GHA failures are unrelated cert issues, or unrelated (in the case of linux-x86) GC test failures. The new tests pass on my Intel Mac laptop.

phohensee avatar Aug 30 '24 16:08 phohensee

GHA failures are unrelated cert issues, or unrelated (in the case of linux-x86) GC test failures. The new tests pass on my Intel Mac laptop.

Thanks for confirming the new tests pass, as they won't be covered by the GHA tiers. As to the failing GHA tests, I agree these are unrelated and we should consider excluding the failing ones. I confirmed even more of the cacert tests are failing on trunk (where they made them manual)

gnu-andrew avatar Sep 02 '24 15:09 gnu-andrew

Approving now but please wait for 8u442 to open before committing (see #572) /approve yes

gnu-andrew avatar Sep 02 '24 15:09 gnu-andrew

@gnu-andrew 8315731: The approval request has been approved.

openjdk[bot] avatar Sep 02 '24 15:09 openjdk[bot]

Approving now but please wait for 8u442 to open before committing (see #572) /approve yes

Good to go now.

gnu-andrew avatar Sep 04 '24 15:09 gnu-andrew

/integrate

mrserb avatar Sep 10 '24 07:09 mrserb

Going to push as commit b7348860e89a8aa4466caf7eea1fe628f5b8942a.

openjdk[bot] avatar Sep 10 '24 07:09 openjdk[bot]

@mrserb Pushed as commit b7348860e89a8aa4466caf7eea1fe628f5b8942a.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Sep 10 '24 07:09 openjdk[bot]