jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

Open mrserb opened this issue 1 year ago • 9 comments

Hi all,

This pull request contains a backport of commit c640fe42 from the openjdk/jdk repository.

The commit being backported was authored by lawrence.andrews on 5 Sep 2021 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-7188098 needs maintainer approval

Issue

  • JDK-7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/515/head:pull/515
$ git checkout pull/515

Update a local copy of the PR:
$ git checkout pull/515
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/515/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 515

View PR using the GUI difftool:
$ git pr show -t 515

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/515.diff

Webrev

Link to Webrev Comment

mrserb avatar Jun 09 '24 04:06 mrserb

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jun 09 '24 04:06 bridgekeeper[bot]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • edbdf0538df3fe764ea6a109c3e07cb145dbfe48: 8336928: GHA: Bundle artifacts removal broken
  • 1ca84ad59a4db33ab43cebc7d78ee99f87455be1: 8305400: ISO 4217 Amendment 175 Update
  • ea76f37ddb113b84f5421d64e687e1b6b7a13ea6: 8338144: [8u] Remove duplicate license files
  • fb0a658dd5dc417fa4ce74b17d10c507ed6bc66f: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
  • 4538bba37c61982e3122dbf83fa2ea5c70434641: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415
  • 4106121e0ae42d644e45c6eab9037874110ed670: 8281096: Flags introduced by configure script are not passed to ADLC build
  • b4fc8e711c5953823e687f8cc133aac5e8fdd577: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097
  • 09bab6e4c31531975ab6461832d4618dc9759ca9: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials
  • d4adbe339c3dd09a7f431da2c909b03560c6579e: 8152207: Perform array bound checks while getting a length of bytecode instructions
  • 047b08a891d837efb925448b6334679f772ef0e5: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • ... and 32 more: https://git.openjdk.org/jdk8u-dev/compare/61dde50292198f9f35f906eef00b1fd002a19074...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jun 09 '24 04:06 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jun 09 '24 04:06 openjdk[bot]

/clean the fix is identical to openjdk/jdk

mrserb avatar Jun 10 '24 01:06 mrserb

@mrserb This backport pull request is now marked as clean

openjdk[bot] avatar Jun 10 '24 01:06 openjdk[bot]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jun 10 '24 01:06 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jun 10 '24 01:06 mlbridge[bot]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 08 '24 01:07 bridgekeeper[bot]

keep open

mrserb avatar Jul 11 '24 00:07 mrserb

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 08 '24 03:08 bridgekeeper[bot]

/integrate

mrserb avatar Aug 21 '24 18:08 mrserb

Going to push as commit aa443466bbe5f8326ab595ef9f4a2fa9919250e9. Since your change was applied there have been 52 commits pushed to the master branch:

  • fc33f51c24d21e30a73ce3a70ba961651b483672: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 8867d017b18ad7cd8842b9324c5c031a44a58064: 8193682: Infinite loop in ZipOutputStream.close()
  • 5c7f201af69a500b06a345f84a5b1ce550b605b2: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
  • 933c78ebd5be5aedc2181b95917933dffe7e279c: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e82ebd3640c7999e094903874c9ac7f2391: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • 855480b9336976cfdeea6ff5f57a712e4119e61a: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
  • 4c9c5a4275550fee0dbf46697255c147a8dc98b6: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
  • 8b28c35f2efe5f4d6bd2f4e36720ca6a529836dd: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
  • 2afd9188fa17d748dca15bcdc1f39bdb1c6dfca9: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 439e910420ab9e1ca7c4645bb20634bc7cdbbe57: 8321480: ISO 4217 Amendment 176 Update
  • ... and 42 more: https://git.openjdk.org/jdk8u-dev/compare/61dde50292198f9f35f906eef00b1fd002a19074...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 21 '24 18:08 openjdk[bot]

@mrserb Pushed as commit aa443466bbe5f8326ab595ef9f4a2fa9919250e9.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 21 '24 18:08 openjdk[bot]