jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes

Open mrserb opened this issue 1 year ago • 8 comments

Hi all,

This pull request contains a backport of commit 9b1d6d66 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin.

Thanks!


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8316328 needs maintainer approval

Issue

  • JDK-8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/506/head:pull/506
$ git checkout pull/506

Update a local copy of the PR:
$ git checkout pull/506
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 506

View PR using the GUI difftool:
$ git pr show -t 506

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/506.diff

Webrev

Link to Webrev Comment

mrserb avatar May 24 '24 02:05 mrserb

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 24 '24 02:05 bridgekeeper[bot]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 7c13bd84274ffdd437ffcc3b39694f9efce0ec1b: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option
  • 7d36fed8e01c6ee0a1b301a379df5dae8afa960d: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
  • 49425166c201e73dd954bd033ea6e33f4a9811b3: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3c19f1276e92c6955600730b8d3353c4ea: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad460815f2637d53df37b27b68e64d5b75b: 8318951: Additional negative value check in JPEG decoding

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 24 '24 02:05 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar May 24 '24 02:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 24 '24 04:05 mlbridge[bot]

GHA failures appear unrelated.

phohensee avatar May 30 '24 00:05 phohensee

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 27 '24 01:06 bridgekeeper[bot]

keep open

mrserb avatar Jun 27 '24 08:06 mrserb

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 25 '24 09:07 bridgekeeper[bot]

keep open

mrserb avatar Aug 12 '24 17:08 mrserb

/approve yes

gnu-andrew avatar Aug 30 '24 00:08 gnu-andrew

@gnu-andrew 8316328: The approval request has been approved.

openjdk[bot] avatar Aug 30 '24 00:08 openjdk[bot]

/integrate

mrserb avatar Aug 30 '24 01:08 mrserb

Going to push as commit 8b0fedccb89308b7dfdf1ab7c7801b4e3a786ec2. Since your change was applied there have been 5 commits pushed to the master branch:

  • 7c13bd84274ffdd437ffcc3b39694f9efce0ec1b: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option
  • 7d36fed8e01c6ee0a1b301a379df5dae8afa960d: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
  • 49425166c201e73dd954bd033ea6e33f4a9811b3: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3c19f1276e92c6955600730b8d3353c4ea: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad460815f2637d53df37b27b68e64d5b75b: 8318951: Additional negative value check in JPEG decoding

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 30 '24 01:08 openjdk[bot]

@mrserb Pushed as commit 8b0fedccb89308b7dfdf1ab7c7801b4e3a786ec2.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 30 '24 01:08 openjdk[bot]