jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8298527: Cygwin's uname -m returns different string than before

Open sendaoYan opened this issue 1 year ago • 17 comments
trafficstars

Hi all,

This pull request contains a backport of JDK-8298527, commit 1da982b4 from the openjdk/jdk17u-dev repository. I had to resolve because RISCV64 was not handled in jdk8u-dev yet.

The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken.

This backport not clean bacause of file common/autoconf/build-aux/config.guess was move to make/autoconf/build-aux/config.guess

Thanks!


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8298527 needs maintainer approval

Issue

  • JDK-8298527: Cygwin's uname -m returns different string than before (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/499/head:pull/499
$ git checkout pull/499

Update a local copy of the PR:
$ git checkout pull/499
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 499

View PR using the GUI difftool:
$ git pr show -t 499

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/499.diff

Webrev

Link to Webrev Comment

sendaoYan avatar May 16 '24 07:05 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 16 '24 07:05 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar May 16 '24 07:05 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar May 16 '24 07:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 16 '24 08:05 mlbridge[bot]

/approval request Backport of JDK-8298527, enhancement the config.guess to support linux-riscv64 etc, the risk is low.

sendaoYan avatar May 16 '24 08:05 sendaoYan

@sendaoYan 8298527: The approval request has been created successfully.

openjdk[bot] avatar May 16 '24 08:05 openjdk[bot]

The GHA test runner report two failures, the two failures is environmental issue, unreleated to this PR:

  1. ppc64le build fail on Create sysroot stage: E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages
  2. s390x build fail on Create sysroot stage: E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-s390x/Packages

sendaoYan avatar May 16 '24 08:05 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 13 '24 11:06 bridgekeeper[bot]

Hi, could anyone take look this PR.

sendaoYan avatar Jun 13 '24 12:06 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 11 '24 14:07 bridgekeeper[bot]

/open

sendaoYan avatar Jul 11 '24 15:07 sendaoYan

@sendaoYan This pull request is already open

openjdk[bot] avatar Jul 11 '24 15:07 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Aug 08 '24 21:08 bridgekeeper[bot]

/open

sendaoYan avatar Aug 09 '24 01:08 sendaoYan

@sendaoYan This pull request is already open

openjdk[bot] avatar Aug 09 '24 01:08 openjdk[bot]

Before this PR has been reviewed, the approval label should not seted. /approval cancel

sendaoYan avatar Aug 29 '24 15:08 sendaoYan

@sendaoYan 8298527: The approval request has been cancelled successfully.

openjdk[bot] avatar Aug 29 '24 15:08 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 26 '24 19:09 bridgekeeper[bot]

/open

sendaoYan avatar Sep 27 '24 01:09 sendaoYan

@sendaoYan This pull request is already open

openjdk[bot] avatar Sep 27 '24 01:09 openjdk[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 25 '24 06:10 bridgekeeper[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 31 '24 03:10 bridgekeeper[bot]

/open

sendaoYan avatar Oct 31 '24 03:10 sendaoYan

@sendaoYan This pull request is already open

openjdk[bot] avatar Oct 31 '24 03:10 openjdk[bot]

I think it's not quite strong necessary to backport this PR, sorry for the interrupt.

sendaoYan avatar Nov 21 '24 02:11 sendaoYan