jdk8u-dev
jdk8u-dev copied to clipboard
8298527: Cygwin's uname -m returns different string than before
Hi all,
This pull request contains a backport of JDK-8298527, commit 1da982b4 from the openjdk/jdk17u-dev repository. I had to resolve because RISCV64 was not handled in jdk8u-dev yet.
The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken.
This backport not clean bacause of file common/autoconf/build-aux/config.guess was move to make/autoconf/build-aux/config.guess
Thanks!
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8298527 needs maintainer approval
Issue
- JDK-8298527: Cygwin's uname -m returns different string than before (Bug - P3)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/499/head:pull/499
$ git checkout pull/499
Update a local copy of the PR:
$ git checkout pull/499
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/499/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 499
View PR using the GUI difftool:
$ git pr show -t 499
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/499.diff
Webrev
:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
This backport pull request has now been updated with issue from the original commit.
/approval request Backport of JDK-8298527, enhancement the config.guess to support linux-riscv64 etc, the risk is low.
@sendaoYan 8298527: The approval request has been created successfully.
The GHA test runner report two failures, the two failures is environmental issue, unreleated to this PR:
- ppc64le build fail on
Create sysrootstage:E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages - s390x build fail on
Create sysrootstage:E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-s390x/Packages
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Hi, could anyone take look this PR.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/open
@sendaoYan This pull request is already open
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/open
@sendaoYan This pull request is already open
Before this PR has been reviewed, the approval label should not seted. /approval cancel
@sendaoYan 8298527: The approval request has been cancelled successfully.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/open
@sendaoYan This pull request is already open
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/open
@sendaoYan This pull request is already open
I think it's not quite strong necessary to backport this PR, sorry for the interrupt.