jdk8u-dev
jdk8u-dev copied to clipboard
openjdk
8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism
Hi all,
I would like to backport this patch to improve test maintainability. This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch.
Testing: All tests under jdk/test/com/sun/jdi
Thank you.
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8048892 needs maintainer approval
Integration blocker
⚠️ Dependency #492 must be integrated first
Issue
- JDK-8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/493/head:pull/493
$ git checkout pull/493
Update a local copy of the PR:
$ git checkout pull/493
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/493/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 493
View PR using the GUI difftool:
$ git pr show -t 493
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/493.diff
Webrev
:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into pr/492 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
@ktakakuri The target branch of this pull request no longer exists. Please retarget this pull request. Please issue this command again once the problem has been resolved.
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
@ktakakuri The target branch of this pull request no longer exists. Please retarget this pull request. Please issue this command again once the problem has been resolved.
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!