8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use

[ktakakuri]

trafficstars

Hi all,

This is a backport of JDK-8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use. The JMXStartStopTest.java test failures reported in this issue also occur in JDK8. This backport improves testing to use a dynamically allocated port.

testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java

With this fix alone, the test remains unstable. Backporting with JDK-8035395 makes JMXStartStopTest.java more stable.

Thank you.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8035395 needs maintainer approval

Issue

• JDK-8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use (Bug - P4 - Requested)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/429/head:pull/429
$ git checkout pull/429

Update a local copy of the PR:
$ git checkout pull/429
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/429/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 429

View PR using the GUI difftool:
$ git pr show -t 429

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/429.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 00: Full (98cff0fe)

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[phohensee]

windows-x86 GHA builds seem broken due to unrelated issue.

[openjdk[bot]]

@ktakakuri This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 68 new commits pushed to the master branch:

• bfb1a7d1e34ed2e0e88e67a5f77410de097fc489: 4660158: TTY: NumberFormatException while trying to set values by 'set' command
• 0357abbfe41fc3dc244c30e48f8f9193219ea406: 8324632: Update Zlib Data Compression Library to Version 1.3.1
• 61dde50292198f9f35f906eef00b1fd002a19074: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
• 8892b817af1b25520b05608a30ea539dd0c0b25f: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• 9da7380962e4532c880235c1dc74c9333a1b52f1: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
• 9a7aa794506ded4771d8a29356c20f7c0c6e8327: 8333669: [8u] GHA: Dead VS2010 download link
• 663ecc703dd8526178e3aab0036ddeac8767ff0f: 8333126: Bump update version of OpenJDK: 8u432
• db860f0cf8bd5b47516508be170f930710e5e396: 8326529: JFR: Test for CompilerCompile events fails due to time out
• 012f59c7f63fc44c1949d905203ea3f449087cd4: 8316138: Add GlobalSign 2 TLS root certificates
• 7bcaeb5ff10a0269b43743a4ba6529615dde7aa2: 8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
• ... and 58 more: https://git.openjdk.org/jdk8u-dev/compare/552c6866d8ad71ef247b5303f78fa7a65506aea9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[ktakakuri]

/approval request I would like to backport this issue to 8u because the test fails also with jdk8. There is no risk because it is a test-only fix. Only with this fix , the test will not passed. This backport is followed by a JDK-8066708 backport to stabilize the test.

[openjdk[bot]]

@ktakakuri 8035395: The approval request has been created successfully.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk[bot]]

@ktakakuri This pull request is now open

[gnu-andrew]

/approve yes

[openjdk[bot]]

@gnu-andrew 8035395: The approval request has been approved.

[ktakakuri]

/integrate

[openjdk[bot]]

@ktakakuri Your change (at version 98cff0fe2875d1aaee5702c5359796488d57aa13) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk[bot]]

Going to push as commit 6abb3f27b9a535f741c7d3a8dfa0d6b811263a9e. Since your change was applied there have been 69 commits pushed to the master branch:

• 683860572c87e9c89ba7de45264c1d32b195db8c: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
• bfb1a7d1e34ed2e0e88e67a5f77410de097fc489: 4660158: TTY: NumberFormatException while trying to set values by 'set' command
• 0357abbfe41fc3dc244c30e48f8f9193219ea406: 8324632: Update Zlib Data Compression Library to Version 1.3.1
• 61dde50292198f9f35f906eef00b1fd002a19074: 8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1
• 8892b817af1b25520b05608a30ea539dd0c0b25f: 8326521: JFR: CompilerPhase event test fails on windows 32 bit
• 9da7380962e4532c880235c1dc74c9333a1b52f1: 8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye
• 9a7aa794506ded4771d8a29356c20f7c0c6e8327: 8333669: [8u] GHA: Dead VS2010 download link
• 663ecc703dd8526178e3aab0036ddeac8767ff0f: 8333126: Bump update version of OpenJDK: 8u432
• db860f0cf8bd5b47516508be170f930710e5e396: 8326529: JFR: Test for CompilerCompile events fails due to time out
• 012f59c7f63fc44c1949d905203ea3f449087cd4: 8316138: Add GlobalSign 2 TLS root certificates
• ... and 59 more: https://git.openjdk.org/jdk8u-dev/compare/552c6866d8ad71ef247b5303f78fa7a65506aea9...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@phohensee @ktakakuri Pushed as commit 6abb3f27b9a535f741c7d3a8dfa0d6b811263a9e.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.