jdk8u-dev
jdk8u-dev copied to clipboard
openjdk
8312065: Socket.connect does not timeout when profiling
Hi,
This pull request contains the backport of JDK-8312065, commit 1ce12c4 from the openjdk/jdk17u-dev repository.
I added the test B8312065.java. The test will fail on the JDK8 without my fix, and it will pass on the JDK8 containing my fix.
This test relies on libNativeThread to get the OS thread ID of the Java threads, and send signals to OS threads.
The libNativeThread was introduced to test the fix for JDK-8237858. However, JDK-8237858 only exists in Java 10 and above. There is no JDK-8237858 problem on Java 8, so JDK-8237858 cannot be backported to Java 8.
In order to use libNativeThread, I copied it to my backport.
I ran all the jtreg tests in test/jdk/java/net/ServerSocket,test/jdk/java/net/Socket,test/jdk/java/net/SocketOption,test/jdk/java/net/ipv6 on my host, all passed.
Thanks!
Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8312065 needs maintainer approval
Issue
- JDK-8312065: Socket.connect does not timeout when profiling (Bug - P4)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/410/head:pull/410
$ git checkout pull/410
Update a local copy of the PR:
$ git checkout pull/410
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/410/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 410
View PR using the GUI difftool:
$ git pr show -t 410
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/410.diff
Webrev
:wave: Welcome back yanglong1010! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.
@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Gentle ping. I would be very grateful if anyone could help with the review.
@yanglong1010 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@yanglong1010 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.