jdk8u-dev
jdk8u-dev copied to clipboard
openjdk
8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese
I would like to fix this issue because the test dose not work as intended. Could someone please review it?
Progress
- [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8320964 needs maintainer approval
Issue
- JDK-8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese (Bug - P4)
Reviewers
- Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to d29d1e5c
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/400/head:pull/400
$ git checkout pull/400
Update a local copy of the PR:
$ git checkout pull/400
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/400/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 400
View PR using the GUI difftool:
$ git pr show -t 400
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/400.diff
Webrev
:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
linux-x86 failure seems unrelated, but please have a look at the windows-x64 failure.
⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
@ktakakuri This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese
Reviewed-by: phh, andrew
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.
At the time when this comment was updated there had been 41 new commits pushed to the master branch:
- fc15e99a3218a88434c27da1d7d09a01c592d8f9: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
- ddce2b5d39cb780c84d0c4d3bf01df2fe5d3d989: 8299677: Formatter.format might take a long time to format an integer or floating-point
- c8eb027b59dbb12150a1edd926b14fc2f6753bbd: 8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build
- 16ea85b54115073c6c22377b817878fe112b2100: 8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes
- 54f7734c7cea3a20d49103c4387ed9023992e5a6: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
- 385e34d860965a77df355edfd8c1d99af5afe38c: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
- 44eac48705dd89f20cda5c4384cbecf417555eb1: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"
- a0715ab4bc71642203324a2c06774aacee35fda7: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
- b499ea7ec2ffb2211a67d38b3bd689a77866cb0d: 8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\'t convert 2147483648 to int" not found
- b1e2ea81f45d9b144e1de8d16b2b698f1788d4d7: 8279164: Disable TLS_ECDH_* cipher suites
- ... and 31 more: https://git.openjdk.org/jdk8u-dev/compare/1db6a7606c297fd87d5f143cac40e7652b94404c...master
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
- I run the test on English Windows and also found to occur on the following environment:
$ systeminfo
OS Name: Microsoft Windows Server 2016 Standard
System Locale: en-us;English (United States)
$ sed --version
sed (GNU sed) 4.8
Packaged by Cygwin (4.8-1)
Copyright (C) 2020 Free Software Foundation, Inc.
- I fixed copyright and added the bug ID.
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
Sorry for the delay, I've been caught up with the upcoming release. Please apply for approval and we can get this in.
/approval request I would like to fix this issue because it always fails in regression testing, resulting in extra costs for checking the test results. There is no risk. Testing: I tested it on Windows and Linux.
@ktakakuri Your change (at version 052174e588216224904b82c2351ca5b005efc9fa) is now ready to be sponsored by a Committer.
Going to push as commit 21e4278aeed3db5eec63679ee1417c3407daf8e7.
Since your change was applied there have been 41 commits pushed to the master branch:
- fc15e99a3218a88434c27da1d7d09a01c592d8f9: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"
- ddce2b5d39cb780c84d0c4d3bf01df2fe5d3d989: 8299677: Formatter.format might take a long time to format an integer or floating-point
- c8eb027b59dbb12150a1edd926b14fc2f6753bbd: 8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build
- 16ea85b54115073c6c22377b817878fe112b2100: 8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes
- 54f7734c7cea3a20d49103c4387ed9023992e5a6: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
- 385e34d860965a77df355edfd8c1d99af5afe38c: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
- 44eac48705dd89f20cda5c4384cbecf417555eb1: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging"
- a0715ab4bc71642203324a2c06774aacee35fda7: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
- b499ea7ec2ffb2211a67d38b3bd689a77866cb0d: 8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\'t convert 2147483648 to int" not found
- b1e2ea81f45d9b144e1de8d16b2b698f1788d4d7: 8279164: Disable TLS_ECDH_* cipher suites
- ... and 31 more: https://git.openjdk.org/jdk8u-dev/compare/1db6a7606c297fd87d5f143cac40e7652b94404c...master
Your commit was automatically rebased without conflicts.
@gnu-andrew @ktakakuri Pushed as commit 21e4278aeed3db5eec63679ee1417c3407daf8e7.
:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.