8160974: [TESTBUG] Mark more headful tests with @key headful.

[ktakakuri]

trafficstars

This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful.

This patch has already been applied to OracleJDK8. As noted in the Bug Issue comments, some tests do not exist in 8u.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [ ] JDK-8160974 needs maintainer approval
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. (Bug - P4 - Requested)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/383/head:pull/383
$ git checkout pull/383

Update a local copy of the PR:
$ git checkout pull/383
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 383

View PR using the GUI difftool:
$ git pr show -t 383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/383.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 05: Full (ebbd2607)
• 04: Full - Incremental (341e9a82)
• 03: Full - Incremental (df1f54df)
• 02: Full - Incremental (757abee7)
• 01: Full - Incremental (7fb82b04)
• 00: Full (8983a17a)

[jerboaa]

There are test failures. See GHA. E.g.:

 Error: Test clashes with another test with a similar name:
  /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.java
  /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.html

Please fix.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk[bot]]

@ktakakuri This pull request is now open

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

To backport this patch, the following change has been made, other than minor conflict resolution.

• The following 56 tests do not exist in jdk8u, and skipped. jdk/test/com/sun/java/accessibility/util/8051626/Bug8051626.java jdk/test/java/awt/Component/GetScreenLocTest/GetScreenLocTest.java jdk/test/java/awt/Dialog/ChildProperties/ChildDialogProperties.java jdk/test/java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java jdk/test/java/awt/PrintJob/PrinterException.java jdk/test/java/awt/TextField/TextFieldEditing/TextFieldEditing.java jdk/test/java/awt/Window/ChildProperties/ChildWindowProperties.java jdk/test/java/awt/datatransfer/UnicodeTransferTest/UnicodeTransferTest.java jdk/test/java/awt/image/multiresolution/MenuMultiresolutionIconTest.java jdk/test/java/awt/image/multiresolution/MultiResolutionJOptionPaneIconTest.java jdk/test/java/awt/print/PrinterJob/LandscapeStackOverflow.java jdk/test/javax/swing/Action/8133039/bug8133039.java jdk/test/javax/swing/GroupLayout/8013566/bug8013566.java jdk/test/javax/swing/GroupLayout/8079640/bug8079640.java jdk/test/javax/swing/InputVerifier/VerifyTarget/VerifyTargetTest.java jdk/test/javax/swing/JButton/PressedButtonRightClickTest.java jdk/test/javax/swing/JColorChooser/Test8051548.java jdk/test/javax/swing/JDialog/Transparency/TransparencyTest.java jdk/test/javax/swing/JEditorPane/8146319/JEditorPaneTest.java jdk/test/javax/swing/JFileChooser/8016665/JFileChooserOrientation.java jdk/test/javax/swing/JFileChooser/8041694/bug8041694.java jdk/test/javax/swing/JFileChooser/DeserializedJFileChooser/DeserializedJFileChooserTest.java jdk/test/javax/swing/JInternalFrame/4769772/TestJInternalFrameIconify.java jdk/test/javax/swing/JInternalFrame/8069348/bug8069348.java jdk/test/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java jdk/test/javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java jdk/test/javax/swing/JInternalFrame/NormalBoundsTest.java jdk/test/javax/swing/JMenu/4213634/bug4213634.java jdk/test/javax/swing/JOptionPane/8139213/OptionPaneTest.java jdk/test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java jdk/test/javax/swing/JProgressBar/8015748/JProgressBarOrientationRobotTest.java jdk/test/javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java jdk/test/javax/swing/JRootPane/SilenceOfDeprecatedMenuBar/SilenceOfDeprecatedMenuBar.java jdk/test/javax/swing/JScrollPane/bug8044371.java jdk/test/javax/swing/JSpinner/6421058/bug6421058.java jdk/test/javax/swing/JSpinner/WrongEditorTextFieldFont/WrongEditorTextFieldFont.java jdk/test/javax/swing/JTabbedPane/8017284/bug8017284.java jdk/test/javax/swing/JTabbedPane/8134116/Bug8134116.java jdk/test/javax/swing/JTabbedPane/8137169/ScrollableTabbedPaneTest.java jdk/test/javax/swing/JTable/6894632/bug6894632.java jdk/test/javax/swing/JTableHeader/4473075/bug4473075.java jdk/test/javax/swing/JTextArea/8149849/DNDTextToScaledArea.java jdk/test/javax/swing/JTextPane/bug8025082.java jdk/test/javax/swing/JToolTip/6219960/bug6219960.java jdk/test/javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java jdk/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java jdk/test/javax/swing/LookAndFeel/8146276/NimbusGlueTest.java jdk/test/javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java jdk/test/javax/swing/plaf/basic/BasicRootPaneUI/HiddenDefaultButtonTest.java jdk/test/javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java jdk/test/javax/swing/plaf/synth/8040328/bug8040328.java jdk/test/javax/swing/plaf/synth/SynthScrollbarThumbPainter/SynthScrollbarThumbPainterTest.java jdk/test/javax/swing/text/NavigationFilter/8058305/bug8058305.java jdk/test/javax/swing/text/TableView/I18nLayoutTest.java jdk/test/javax/swing/text/html/8031109/bug8031109.java jdk/test/javax/swing/text/rtf/RTFWriteParagraphAlignTest.java

• jdk/test/java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java skipped The bacported patch JDK-8252470 already introduced the headful keyword.

• add headful keyword for jdk/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.html At the time the original patch was applied, JDK-8144164 had been already applied. JDK-8144164 integrates MouseClickRequestFocusRaceTest.html and MouseClickRequestFocusRaceTest.java. Therefore, it is preferable to add headful keyword to MouseClickRequestFocusRaceTest.html.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

@ktakakuri this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8160974
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[ktakakuri]

I resolved the conflict.

• jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java "key headful" was already added in master branch, so I adopted master.

[ktakakuri]

There are a lot of revisions, but could someone please review them?

[openjdk[bot]]

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[ktakakuri]

/approval request This is mostly a clean backport of JDK9, so there is no risk. As noted in the Bug Issue comments, some tests do not exist in JDK8.

[openjdk[bot]]

@ktakakuri 8160974: The approval request has been created successfully.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Contrary to the approval request, this does not seem like a "mostly clean backport" if 56 files are being skipped. It will take some time to review this as with JDK-8159690

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request. I comment to not close.