jdk8u-dev
jdk8u-dev copied to clipboard
openjdk
8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
Testing: java/awt javax/swing ButtonGroupLayoutTraversalTest.java bug8033699.java DefaultButtonModelCrashTest.java on Windows x86_64
Progress
- [ ] JDK-8154043 needs maintainer approval
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)
- [ ] JDK-8182577 needs maintainer approval
Issues
- JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. (Bug - P3 - Rejected)
- JDK-8182577: Exception when Tab key moves focus to a JCheckbox with a custom ButtonModel (Bug - P3)
Reviewers
- Paul Hohensee (@phohensee - Reviewer)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/285/head:pull/285
$ git checkout pull/285
Update a local copy of the PR:
$ git checkout pull/285
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/285/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 285
View PR using the GUI difftool:
$ git pr show -t 285
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/285.diff
Using Webrev
:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
![bridgekeeper[bot] avatar](https://avatars.githubusercontent.com/u/41768318?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mrserb I issued this PR in relation to https://github.com/openjdk/jdk8u-dev/pull/212. Could you please review this backport?
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ktakakuri This change is no longer ready for integration - check the PR body for details.
⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
As this fix includes the test from JDK-8182577, please use /isssue add JDK-8182577.
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
As this fix includes the test from JDK-8182577, please use
/isssue add JDK-8182577.
Still relevant.
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
@ktakakuri Unknown command isssue - for a list of valid commands use /help.
@ktakakuri
Adding additional issue to issue list: 8182577: Exception when Tab key moves focus to a JCheckbox with a custom ButtonModel.
At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.