jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8301631: [8u] Enable full builds for additional Linux builds

Open gnu-andrew opened this issue 2 years ago • 16 comments

Let's try to enable full builds for the additional (i.e. cross-compilation to s390x, aarch64, arm & ppc64le) builds, so the JDK native code gets built as well.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8301631 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8301631: [8u] Enable full builds for additional Linux builds (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/259/head:pull/259
$ git checkout pull/259

Update a local copy of the PR:
$ git checkout pull/259
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 259

View PR using the GUI difftool:
$ git pr show -t 259

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/259.diff

Using Webrev

Link to Webrev Comment

gnu-andrew avatar Feb 01 '23 17:02 gnu-andrew

:wave: Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 01 '23 17:02 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Feb 01 '23 17:02 mlbridge[bot]

Seems, there are problems with Ubuntu repos, used by GitHub runners, at the moment: https://github.com/actions/runner-images/issues/7048 :(

zzambers avatar Feb 06 '23 21:02 zzambers

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 07 '23 00:03 bridgekeeper[bot]

I'll have another look at this after the 8u372 release is out of the way. I'll likely include a workaround for the Ubuntu issue I've seen suggested so we don't hit that again in future.

gnu-andrew avatar Mar 27 '23 15:03 gnu-andrew

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 25 '23 01:04 bridgekeeper[bot]

@gnu-andrew This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar May 23 '23 06:05 bridgekeeper[bot]

/open

gnu-andrew avatar Aug 07 '23 17:08 gnu-andrew

@gnu-andrew This pull request is now open

openjdk[bot] avatar Aug 07 '23 17:08 openjdk[bot]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 04 '23 20:09 bridgekeeper[bot]

@gnu-andrew This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Oct 03 '23 04:10 bridgekeeper[bot]

/open

gnu-andrew avatar Aug 29 '25 21:08 gnu-andrew

@gnu-andrew This pull request is now open

openjdk[bot] avatar Aug 29 '25 21:08 openjdk[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Aug 29 '25 21:08 openjdk[bot]

@gnu-andrew this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8301631
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

openjdk[bot] avatar Aug 29 '25 21:08 openjdk[bot]

@gnu-andrew This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 25 '25 05:10 bridgekeeper[bot]