8074883: Tab key should move to focused button in a button group

[ktakakuri]

trafficstars

This is a backport of JDK-8074883: Tab key should move to focused button in a button group.

I would like to backport the patch to OpenJDK8u. Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9.

• Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION.

• ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController.

• Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. ToggleButton.getGroupSelection() returns itself, so no circular call occurs.

• I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION.

• Only Swing components replace default RequestFocusController to JComponent.focusController. The focusController returns true except for Swing, so this change does not affect other components.

Testing: build on Windows x86_64 java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [ ] JDK-8074883 needs maintainer approval
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8074883: Tab key should move to focused button in a button group (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/212/head:pull/212
$ git checkout pull/212

Update a local copy of the PR:
$ git checkout pull/212
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 212

View PR using the GUI difftool:
$ git pr show -t 212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/212.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 00: Full (c578963c)

[ktakakuri]

Could someone please review this backport?

[mrserb]

Looking into this fiix

[mrserb]

It looks like this change caused a regression fixed by the JDK-8182577(probably some ofthe issues were fixed as well?), please chech that it is possible to backport it as well.

[ktakakuri]

DefaultButtonModelCrashTest passed even before this backport was applied. Does this mean that JDK-8182577 is already fixed in 8u?

[mrserb]

One of the comment in the JDK-8182577 mentioned that that test works fine in jdk8 and failed since jdk9. So that was a regression, possibly caused by the change you requested to backport or maybe some other.

[ktakakuri]

DefaultButtonModelCrashTest passed even after applying this backport. Is there any proof needed?

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

@mrserb Is there anything else that needs to be confirmed?

[mrserb]

It needs to check why the same patch caused regression in jdk9, something is missing(not backported) in jdk8? If some other patch is missing we should try to backport it first, then backport this one, and then backport the JDK-8182577.

[ktakakuri]

I issued a PR for JDK-8154043 and JDK-8182577. https://github.com/openjdk/jdk8u-dev/pull/285 Thank you.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

@mrserb Could you please review the backport? https://github.com/openjdk/jdk8u-dev/pull/285

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk[bot]]

@ktakakuri This pull request is now open

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Where are we with this one? Is it waiting on #285?

[ktakakuri]

Yes, #285 needs to be merged first and then this PR.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk[bot]]

@ktakakuri This pull request is now open

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk[bot]]

@ktakakuri This pull request is now open