jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8337998: CompletionFailure in getEnclosingType attaching type annotations

Open cushon opened this issue 2 weeks ago • 5 comments
trafficstars

This is a backport of JDK-8337998, which is a follow-up to JDK-8341779.


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8337998 needs maintainer approval

Integration blocker

 ⚠️ Dependency #4149 must be integrated first

Issue

  • JDK-8337998: CompletionFailure in getEnclosingType attaching type annotations (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4150/head:pull/4150
$ git checkout pull/4150

Update a local copy of the PR:
$ git checkout pull/4150
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4150

View PR using the GUI difftool:
$ git pr show -t 4150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4150.diff

Using Webrev

Link to Webrev Comment

cushon avatar Nov 01 '25 21:11 cushon

:wave: Welcome back cushon! A progress list of the required criteria for merging this PR into pr/4149 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Nov 01 '25 21:11 bridgekeeper[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Nov 01 '25 21:11 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Nov 01 '25 21:11 openjdk[bot]

⚠️ @cushon This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

openjdk[bot] avatar Nov 01 '25 21:11 openjdk[bot]

Webrevs

mlbridge[bot] avatar Nov 01 '25 21:11 mlbridge[bot]