jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8294314: Minimize disabled warnings in hotspot

Open mrserb opened this issue 3 weeks ago • 9 comments
trafficstars

Hi all,

This pull request contains a backport of commit 7743345f from the openjdk/jdk repository.

The commit being backported was authored by Magnus Ihse Bursie on 17 Oct 2022 and was reviewed by Erik Joelsson and Aleksey Shipilev.

The patch updates the code to handle certain warnings during compilation. It is part of the ongoing effort to migrate JDK 17 to the new toolchain, including Xcode 16, and will make further patches cleaner.

The patch is not clean because the next three are not in jdk17u:

  • https://bugs.openjdk.org/browse/JDK-8286262 -> still need to disable 4996 warning
  • https://bugs.openjdk.org/browse/JDK-8293182 -> still need to disable missing-field-initializers
  • https://bugs.openjdk.org/browse/JDK-8303805 -> still need to disable strict-overflow

The next two are are already in jdk17u so context a little bit different:

  • https://bugs.openjdk.org/browse/JDK-8300169
  • https://bugs.openjdk.org/browse/JDK-8319818

Testing:

  • github actions
  • gcc: 7.3.1, 9.3.1, 10.5.0, 11.4.0, 11.5.0, 13.2.1 and 13.3.0
  • xcode: 26, 26.0.1
  • VS 2022

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8294314 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8294314: Minimize disabled warnings in hotspot (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4143/head:pull/4143
$ git checkout pull/4143

Update a local copy of the PR:
$ git checkout pull/4143
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4143

View PR using the GUI difftool:
$ git pr show -t 4143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4143.diff

Using Webrev

Link to Webrev Comment

mrserb avatar Oct 31 '25 00:10 mrserb