jdk17u-dev
jdk17u-dev copied to clipboard
8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles
Built-in singleton ICC_Profiles could be modified using setData(). Throw an exception for such an attempt. A testcase is included. It is a clean backport. This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle. It requires https://github.com/openjdk/jdk17u-dev/pull/3886 as a prerequisite.
Progress
- [x] Change must not contain extraneous whitespace
- [x] Commit message must refer to an issue
- [ ] JDK-8346465 needs maintainer approval
- [ ] Change requires CSR request JDK-8367128 to be approved
Warnings
⚠️ Patch contains a binary file (test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck/builtIn.icc) ⚠️ Patch contains a binary file (test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck/custom.icc)
Issues
- JDK-8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles (Bug - P3)
- JDK-8367128: Add a check in setData() to restrict the update of Built-In ICC_Profiles (CSR)
Reviewing
Using git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3887/head:pull/3887
$ git checkout pull/3887
Update a local copy of the PR:
$ git checkout pull/3887
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3887/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3887
View PR using the GUI difftool:
$ git pr show -t 3887
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3887.diff