jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset

Open jankratochvil opened this issue 4 months ago • 13 comments
trafficstars

Multithreaded handling of ZIP files can throw an exception.

This backport is far from clean. The last commit resolves the conflicts.

The backport would be a little cleaner if there was backported as a pre-requisite JDK-8321156. But given there is a backward compatibility concern I have not backported it.

(jdk25 already contains it), jdk21, this jdk17.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8347712 needs maintainer approval
  • [ ] JDK-8355975 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issues

  • JDK-8347712: IllegalStateException on multithreaded ZipFile access with non-UTF8 charset (Bug - P3 - Requested)
  • JDK-8355975: ZipFile uses incorrect Charset if another instance for the same ZIP file was constructed with a different Charset (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3720/head:pull/3720
$ git checkout pull/3720

Update a local copy of the PR:
$ git checkout pull/3720
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3720

View PR using the GUI difftool:
$ git pr show -t 3720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3720.diff

Using Webrev

Link to Webrev Comment

jankratochvil avatar Jul 08 '25 13:07 jankratochvil