jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small

Open GoeLin opened this issue 7 months ago • 5 comments
trafficstars

I backport this for parity with 17.0.16-oracle.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8258483 needs maintainer approval

Issue

  • JDK-8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3437/head:pull/3437
$ git checkout pull/3437

Update a local copy of the PR:
$ git checkout pull/3437
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3437

View PR using the GUI difftool:
$ git pr show -t 3437

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3437.diff

GoeLin avatar Apr 04 '25 13:04 GoeLin

:wave: Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Apr 04 '25 13:04 bridgekeeper[bot]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 729b0c7aa59d7b2e53cdaa8b4a1631962951f8d8: 8352649: [17u] guarantee(is_result_safe || is_in_asgct()) failed inside AsyncGetCallTrace

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Apr 04 '25 13:04 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Apr 04 '25 13:04 openjdk[bot]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Apr 04 '25 13:04 openjdk[bot]

Webrevs

mlbridge[bot] avatar Apr 04 '25 13:04 mlbridge[bot]

/integrate

GoeLin avatar Apr 07 '25 15:04 GoeLin

Going to push as commit 4d51cd82c0bcc308a5ab8ea17902d31ec1885201. Since your change was applied there have been 3 commits pushed to the master branch:

  • 36e703ac2b22d605ea4813a7d956d0437ab303f1: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited"
  • 95e6cbd222732fcccc3767e5983df524b9214acb: 8315871: Opensource five more Swing regression tests
  • 729b0c7aa59d7b2e53cdaa8b4a1631962951f8d8: 8352649: [17u] guarantee(is_result_safe || is_in_asgct()) failed inside AsyncGetCallTrace

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Apr 07 '25 15:04 openjdk[bot]

@GoeLin Pushed as commit 4d51cd82c0bcc308a5ab8ea17902d31ec1885201.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Apr 07 '25 15:04 openjdk[bot]