8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly

[satyenme]

Backporting JDK-8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly. Adjusts code to call PhaseValues::intcon(), which is required so the node is properly entered in the GVN's hash table and its type is properly recorded in the GVN's type table. Ran GHA Sanity Checks, and local Tier 1, and Tier 2 tests. Patch is clean.

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8330106 needs maintainer approval

Issue

• JDK-8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3433/head:pull/3433
$ git checkout pull/3433

Update a local copy of the PR:
$ git checkout pull/3433
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3433

View PR using the GUI difftool:
$ git pr show -t 3433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3433.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330106: C2: VectorInsertNode::make() shouldn't call ConINode::make() directly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 226 new commits pushed to the master branch:

• 81874f35484448772c181e40f6cb972525ff3b11: 8342330: C2: "node pinned on loop exit test?" assert failure
• e29909141cd0312b7d696cf2c57ebe561ac31f4b: 8340389: vmTestbase/gc/gctests/PhantomReference/phantom001/TestDescription.java Test exit code: 97 with -Xcomp UseAVX=3
• c2bd339c4af3782b04001b3617720a411e614b8b: 8332551: Test vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java timed out
• ... and 223 more: https://git.openjdk.org/jdk17u-dev/compare/96e8c5652053e4ee424d73834dc55d97838c6eea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[openjdk[bot]]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge[bot]]

Webrevs

• 00: Full (6098d16f)

[satyenme]

/approval request for backport. Adjusts code to call PhaseValues::intcon(), which is required so the node is properly entered in the GVN's hash table and its type is properly recorded in the GVN's type table

Risk: Medium. Change to compiler code which can have broader impact. Change was merged in April 2024 and present in 23, which mitigates risk.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally

[openjdk[bot]]

@satyenme 8330106: The approval request has been created successfully.

[bridgekeeper[bot]]

@satyenme This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[satyenme]

/keepalive

[openjdk[bot]]

@satyenme The pull request is being re-evaluated and the inactivity timeout has been reset.

[satyenme]

/integrate

[openjdk[bot]]

Going to push as commit 5dab2277926bc83ed9875c381dfe0e5c6b429cb8. Since your change was applied there have been 226 commits pushed to the master branch:

• 81874f35484448772c181e40f6cb972525ff3b11: 8342330: C2: "node pinned on loop exit test?" assert failure
• e29909141cd0312b7d696cf2c57ebe561ac31f4b: 8340389: vmTestbase/gc/gctests/PhantomReference/phantom001/TestDescription.java Test exit code: 97 with -Xcomp UseAVX=3
• c2bd339c4af3782b04001b3617720a411e614b8b: 8332551: Test vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java timed out
• ... and 223 more: https://git.openjdk.org/jdk17u-dev/compare/96e8c5652053e4ee424d73834dc55d97838c6eea...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@satyenme Pushed as commit 5dab2277926bc83ed9875c381dfe0e5c6b429cb8.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.