jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError

Open sendaoYan opened this issue 9 months ago • 5 comments
trafficstars

Hi all,

JMH tests org.openjdk.bench.jdk.incubator.vector.MaskQueryOperationsBenchmark report fails "java.lang.NoClassDefFoundError: jdk/incubator/vector/VectorSpecies" in jdk17u-dev repo.

This failure was fixed by JDK-8284960 in main-line repo, I think it's not suitable backport JDK-8284960 to jdk17u-dev. So I create this issue to fix failure.

Change has been verified locally, test-fix only, no risk.

Verify command:

build/linux-x86_64-server-release/images/jdk/bin/java -Djmh.ignoreLock=true -Djava.library.path=$PWD/build/linux-x86_64-server-release/images/test/micro/native --add-opens=java.base/java.io=ALL-UNNAMED --enable-native-access=ALL-UNNAMED --add-opens=java.base/jdk.internal.misc=ALL-UNNAMED --add-opens java.base/sun.security.provider=ALL-UNNAMED --add-opens java.base/com.sun.crypto.provider=ALL-UNNAMED -jar $PWD/build/linux-x86_64-server-release/images/test/micro/benchmarks.jar -jvmArgsPrepend -Djava.library.path=$PWD/build/linux-x86_64-server-release/images/test/micro/native -t 1 -f 1 -wi 2 org.openjdk.bench.jdk.incubator.vector.MaskQueryOperationsBenchmark.testFirstTrueByte

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8349974 needs maintainer approval

Issue

  • JDK-8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3277/head:pull/3277
$ git checkout pull/3277

Update a local copy of the PR:
$ git checkout pull/3277
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3277

View PR using the GUI difftool:
$ git pr show -t 3277

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3277.diff

Using Webrev

Link to Webrev Comment

sendaoYan avatar Feb 13 '25 09:02 sendaoYan

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 13 '25 09:02 bridgekeeper[bot]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349974: [JMH,17u] MaskQueryOperationsBenchmark fails java.lang.NoClassDefFoundError

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 231 new commits pushed to the master branch:

  • bfe6fe226f4ac7a71480e0a7265b615619fd2010: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • ae176b140044d5e7f40fdb0d93cc8acd5238d22f: 8300658: memory_and_swap_limit() reporting wrong values on systems with swapaccount=0
  • 85d0ab55d6bae2aea4368e6668e361db8a9cbd1c: 8353138: Screen capture for test TaskbarPositionTest.java, failure case
  • ... and 228 more: https://git.openjdk.org/jdk17u-dev/compare/4e5176419cdf67562ae3e3d491ba0efe77acb1df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Feb 13 '25 09:02 openjdk[bot]

Webrevs

mlbridge[bot] avatar Feb 13 '25 09:02 mlbridge[bot]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Mar 13 '25 11:03 bridgekeeper[bot]

Could anyone take look this PR.

sendaoYan avatar Mar 13 '25 13:03 sendaoYan

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 10 '25 16:04 bridgekeeper[bot]

Hi, can anyone take look this PR.

sendaoYan avatar Apr 11 '25 00:04 sendaoYan

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Apr 17 '25 20:04 openjdk[bot]

Thanks for the reviews @phohensee.

/approval request Fix a JMH test bug which cause test run fails. Change has been verified locally, test-fix only, no risk.

sendaoYan avatar Apr 18 '25 03:04 sendaoYan

@sendaoYan 8349974: The approval request has been created successfully.

openjdk[bot] avatar Apr 18 '25 03:04 openjdk[bot]

Thanks for the approved.

/integrate

sendaoYan avatar Apr 19 '25 09:04 sendaoYan

Going to push as commit e38a5f6964a3fb0b43ac69b1c6c6294b4f410104. Since your change was applied there have been 232 commits pushed to the master branch:

  • 9bad4b45f08f369d6a55cbd2bafda10438dc93ed: 8316156: ByteArrayInputStream.transferTo causes MaxDirectMemorySize overflow
  • bfe6fe226f4ac7a71480e0a7265b615619fd2010: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • ae176b140044d5e7f40fdb0d93cc8acd5238d22f: 8300658: memory_and_swap_limit() reporting wrong values on systems with swapaccount=0
  • ... and 229 more: https://git.openjdk.org/jdk17u-dev/compare/4e5176419cdf67562ae3e3d491ba0efe77acb1df...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Apr 19 '25 09:04 openjdk[bot]

@sendaoYan Pushed as commit e38a5f6964a3fb0b43ac69b1c6c6294b4f410104.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Apr 19 '25 09:04 openjdk[bot]