jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test

Open GoeLin opened this issue 1 year ago • 5 comments
trafficstars

I backport this for parity with 17.0.14-oracle.


Progress

  • [ ] JDK-8334562 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] JDK-8335344 needs maintainer approval
  • [x] Commit message must refer to an issue

Issues

  • JDK-8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test (Bug - P4)
  • JDK-8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2918/head:pull/2918
$ git checkout pull/2918

Update a local copy of the PR:
$ git checkout pull/2918
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2918

View PR using the GUI difftool:
$ git pr show -t 2918

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2918.diff

Webrev

Link to Webrev Comment

GoeLin avatar Sep 26 '24 06:09 GoeLin

:wave: Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 26 '24 06:09 bridgekeeper[bot]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test
8335344: test/jdk/sun/security/tools/keytool/NssTest.java fails to compile

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • fa0389ecfbf9677cc47dcdb38d2ada8408de6dce: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases
  • f845f8e8588e30b1e7ffd3687da12dd24674ee6a: 8340815: Add SECURITY.md file
  • e3231e69b6843641c419a9bf326f11fa800a85c8: 8339741: RISC-V: C ABI breakage for integer on stack
  • 26010eaea782ba46b1a1dcc11bb0c86ce6072de7: 8320665: update jdk_core at open/test/jdk/TEST.groups
  • 8d61f49d9f2111cb94d94026b65165b2ca8d949c: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
  • c56241eb2ec17369a9538e9bb3ac30e46c585fd4: 8319574: Exec/process tests should be marked as flagless

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Sep 26 '24 06:09 openjdk[bot]

This backport pull request has now been updated with issues from the original commit.

openjdk[bot] avatar Sep 26 '24 06:09 openjdk[bot]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Sep 26 '24 06:09 openjdk[bot]

Webrevs

mlbridge[bot] avatar Sep 26 '24 06:09 mlbridge[bot]

/integrate

GoeLin avatar Oct 01 '24 10:10 GoeLin

Going to push as commit a29f5fb73deff7da2acf811fc062b7a15ae39304. Since your change was applied there have been 7 commits pushed to the master branch:

  • 1c32d3eb86504297dc484d3984ed406edeb74d9d: 8324841: PKCS11 tests still skip execution
  • fa0389ecfbf9677cc47dcdb38d2ada8408de6dce: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases
  • f845f8e8588e30b1e7ffd3687da12dd24674ee6a: 8340815: Add SECURITY.md file
  • e3231e69b6843641c419a9bf326f11fa800a85c8: 8339741: RISC-V: C ABI breakage for integer on stack
  • 26010eaea782ba46b1a1dcc11bb0c86ce6072de7: 8320665: update jdk_core at open/test/jdk/TEST.groups
  • 8d61f49d9f2111cb94d94026b65165b2ca8d949c: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
  • c56241eb2ec17369a9538e9bb3ac30e46c585fd4: 8319574: Exec/process tests should be marked as flagless

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 01 '24 10:10 openjdk[bot]

@GoeLin Pushed as commit a29f5fb73deff7da2acf811fc062b7a15ae39304.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 01 '24 10:10 openjdk[bot]