8339741: RISC-V: C ABI breakage for integer on stack

[robehn]

trafficstars

Hi all,

This pull request contains a backport of commit bfe7f920 from the openjdk/jdk repository.

The commit being backported was authored by Robbin Ehn on 11 Sep 2024 and was reviewed by Fei Yang and Ludovic Henry.

Not clean, locally tested the new jtreg test.

Thanks!

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [x] JDK-8339741 needs maintainer approval

Issue

• JDK-8339741: RISC-V: C ABI breakage for integer on stack (Bug - P3 - Approved)

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2912/head:pull/2912
$ git checkout pull/2912

Update a local copy of the PR:
$ git checkout pull/2912
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2912

View PR using the GUI difftool:
$ git pr show -t 2912

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2912.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[robehn]

/approval request C ABI breakage to native functions using more than 8 arguments, if int/short/char. Not clean, locally sanity tested by executing the new jtreg test, risc-v only.

[openjdk[bot]]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339741: RISC-V: C ABI breakage for integer on stack

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 492 new commits pushed to the master branch:

• 989b975fa5e1151acd62004022ba90a3be7b10dc: 8320586: update manual test/jdk/TEST.groups
• bb7d33ec4d2965d65d71a73eba0864d4600a4d5f: Merge
• 33cd4b41b3815092b7cbbd324845eeae8cf76257: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
• 89a9243cd77c2823e02a8eff641f7642560082ac: 8327401: Some jtreg tests fail on Wayland without any tracking bug
• e77aad9b64028f2a9f88d21721f68faa8ad36b75: 8325616: JFR ZGC Allocation Stall events should record stack traces
• ed2c4b6894f9bca05f5090c1f295dbc8c2e326f0: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
• 668fd088d64fff71b8601d0540cc12f7465c2ad7: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• 9e8a1c0c937ab3c26f02dd74d956dea01e0bd2fa: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect
• 9c36bb90ffa0e69e9bb672a4af5357e7f7d9baa0: 8335530: Java file extension missing in AuthenticatorTest
• 01740fbdbde713b616e26780e400c1af41f25adb: 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem
• ... and 482 more: https://git.openjdk.org/jdk17u-dev/compare/c741b359000ee2c5fe6cfc6a1c43057d95c344aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[openjdk[bot]]

@robehn 8339741: The approval request has been created successfully.

[mlbridge[bot]]

Webrevs

• 00: Full (2c02f936)

[GoeLin]

Why are the tests failing?

[robehn]

One was

E: Tried to extract package, but file already exists. Exit...
Error: Process completed with exit code 1.

The others: This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

[GoeLin]

Wonderful, no runners available :/ . Well I ran it through SAPs testing without issues.

[robehn]

Wonderful, no runners available :/ . Well I ran it through SAPs testing without issues.

Thank you!

[robehn]

/integrate

[openjdk[bot]]

Going to push as commit e3231e69b6843641c419a9bf326f11fa800a85c8. Since your change was applied there have been 495 commits pushed to the master branch:

• 26010eaea782ba46b1a1dcc11bb0c86ce6072de7: 8320665: update jdk_core at open/test/jdk/TEST.groups
• 8d61f49d9f2111cb94d94026b65165b2ca8d949c: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
• c56241eb2ec17369a9538e9bb3ac30e46c585fd4: 8319574: Exec/process tests should be marked as flagless
• 989b975fa5e1151acd62004022ba90a3be7b10dc: 8320586: update manual test/jdk/TEST.groups
• bb7d33ec4d2965d65d71a73eba0864d4600a4d5f: Merge
• 33cd4b41b3815092b7cbbd324845eeae8cf76257: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
• 89a9243cd77c2823e02a8eff641f7642560082ac: 8327401: Some jtreg tests fail on Wayland without any tracking bug
• e77aad9b64028f2a9f88d21721f68faa8ad36b75: 8325616: JFR ZGC Allocation Stall events should record stack traces
• ed2c4b6894f9bca05f5090c1f295dbc8c2e326f0: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
• 668fd088d64fff71b8601d0540cc12f7465c2ad7: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• ... and 485 more: https://git.openjdk.org/jdk17u-dev/compare/c741b359000ee2c5fe6cfc6a1c43057d95c344aa...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@robehn Pushed as commit e3231e69b6843641c419a9bf326f11fa800a85c8.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.