jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity

Open TheRealMDoerr opened this issue 1 year ago • 6 comments
trafficstars

Clean backport of JDK-8340230 from jdk23u.


Progress

  • [x] Change must not contain extraneous whitespace
  • [ ] JDK-8340230 needs maintainer approval
  • [x] Commit message must refer to an issue

Issue

  • JDK-8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2910/head:pull/2910
$ git checkout pull/2910

Update a local copy of the PR:
$ git checkout pull/2910
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2910

View PR using the GUI difftool:
$ git pr show -t 2910

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2910.diff

Webrev

Link to Webrev Comment

TheRealMDoerr avatar Sep 23 '24 12:09 TheRealMDoerr

:wave: Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 23 '24 12:09 bridgekeeper[bot]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • e5b26f543e8020d7b1028fdaf68502cca6e9749f: Merge
  • 1e20c7c4cdbfe7fc9f6883334e60b2e2549399a2: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 963123ad87935b7bb06dbcd710ec541b59cd2724: 8341057: Add 2 SSL.com TLS roots
  • 1928a36adea8acb824ad5498b6487ed34f4784f5: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
  • a29f5fb73deff7da2acf811fc062b7a15ae39304: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test
  • 1c32d3eb86504297dc484d3984ed406edeb74d9d: 8324841: PKCS11 tests still skip execution
  • fa0389ecfbf9677cc47dcdb38d2ada8408de6dce: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases
  • f845f8e8588e30b1e7ffd3687da12dd24674ee6a: 8340815: Add SECURITY.md file
  • e3231e69b6843641c419a9bf326f11fa800a85c8: 8339741: RISC-V: C ABI breakage for integer on stack
  • 26010eaea782ba46b1a1dcc11bb0c86ce6072de7: 8320665: update jdk_core at open/test/jdk/TEST.groups
  • ... and 15 more: https://git.openjdk.org/jdk17u-dev/compare/20bd36c33824ddeac90681ea49af4cd073166c47...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Sep 23 '24 12:09 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Sep 23 '24 12:09 openjdk[bot]

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Sep 23 '24 12:09 openjdk[bot]

Webrevs

mlbridge[bot] avatar Sep 23 '24 12:09 mlbridge[bot]

GHA test failure is unrelated (timeout).

TheRealMDoerr avatar Sep 25 '24 09:09 TheRealMDoerr

/integrate

TheRealMDoerr avatar Oct 02 '24 13:10 TheRealMDoerr

Going to push as commit e7439b7d465ce1b648c5591345e7307146461df3. Since your change was applied there have been 25 commits pushed to the master branch:

  • e5b26f543e8020d7b1028fdaf68502cca6e9749f: Merge
  • 1e20c7c4cdbfe7fc9f6883334e60b2e2549399a2: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 963123ad87935b7bb06dbcd710ec541b59cd2724: 8341057: Add 2 SSL.com TLS roots
  • 1928a36adea8acb824ad5498b6487ed34f4784f5: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
  • a29f5fb73deff7da2acf811fc062b7a15ae39304: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test
  • 1c32d3eb86504297dc484d3984ed406edeb74d9d: 8324841: PKCS11 tests still skip execution
  • fa0389ecfbf9677cc47dcdb38d2ada8408de6dce: 8337966: (fs) Files.readAttributes fails with Operation not permitted on older docker releases
  • f845f8e8588e30b1e7ffd3687da12dd24674ee6a: 8340815: Add SECURITY.md file
  • e3231e69b6843641c419a9bf326f11fa800a85c8: 8339741: RISC-V: C ABI breakage for integer on stack
  • 26010eaea782ba46b1a1dcc11bb0c86ce6072de7: 8320665: update jdk_core at open/test/jdk/TEST.groups
  • ... and 15 more: https://git.openjdk.org/jdk17u-dev/compare/20bd36c33824ddeac90681ea49af4cd073166c47...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Oct 02 '24 13:10 openjdk[bot]

@TheRealMDoerr Pushed as commit e7439b7d465ce1b648c5591345e7307146461df3.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Oct 02 '24 13:10 openjdk[bot]