jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8319574: Exec/process tests should be marked as flagless

Open GoeLin opened this issue 1 year ago • 5 comments
trafficstars

I backport this for parity with 17.0.14-oracle.

Omitted test/jdk/java/lang/ProcessBuilder/ProcessStartLoggingTest.java. That came with "8303392: Runtime.exec and ProcessBuilder.start should use System logger" which is not a candidate for backport.

Omitted test/jdk/java/lang/RuntimeTests/RuntimeExitLogTest.java. That came with "8301627: System.exit and Runtime.exit debug logging" which is not a candidate for backport.


Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] JDK-8319574 needs maintainer approval

Issue

  • JDK-8319574: Exec/process tests should be marked as flagless (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2907/head:pull/2907
$ git checkout pull/2907

Update a local copy of the PR:
$ git checkout pull/2907
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2907/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2907

View PR using the GUI difftool:
$ git pr show -t 2907

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2907.diff

Webrev

Link to Webrev Comment

GoeLin avatar Sep 23 '24 09:09 GoeLin

:wave: Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Sep 23 '24 09:09 bridgekeeper[bot]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319574: Exec/process tests should be marked as flagless

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 989b975fa5e1151acd62004022ba90a3be7b10dc: 8320586: update manual test/jdk/TEST.groups
  • bb7d33ec4d2965d65d71a73eba0864d4600a4d5f: Merge
  • 33cd4b41b3815092b7cbbd324845eeae8cf76257: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
  • 89a9243cd77c2823e02a8eff641f7642560082ac: 8327401: Some jtreg tests fail on Wayland without any tracking bug
  • e77aad9b64028f2a9f88d21721f68faa8ad36b75: 8325616: JFR ZGC Allocation Stall events should record stack traces
  • ed2c4b6894f9bca05f5090c1f295dbc8c2e326f0: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
  • 668fd088d64fff71b8601d0540cc12f7465c2ad7: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
  • 9e8a1c0c937ab3c26f02dd74d956dea01e0bd2fa: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect
  • 9c36bb90ffa0e69e9bb672a4af5357e7f7d9baa0: 8335530: Java file extension missing in AuthenticatorTest

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Sep 23 '24 09:09 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Sep 23 '24 09:09 openjdk[bot]

Webrevs

mlbridge[bot] avatar Sep 23 '24 10:09 mlbridge[bot]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Sep 24 '24 08:09 openjdk[bot]

/integrate

GoeLin avatar Sep 26 '24 11:09 GoeLin

Going to push as commit c56241eb2ec17369a9538e9bb3ac30e46c585fd4. Since your change was applied there have been 9 commits pushed to the master branch:

  • 989b975fa5e1151acd62004022ba90a3be7b10dc: 8320586: update manual test/jdk/TEST.groups
  • bb7d33ec4d2965d65d71a73eba0864d4600a4d5f: Merge
  • 33cd4b41b3815092b7cbbd324845eeae8cf76257: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
  • 89a9243cd77c2823e02a8eff641f7642560082ac: 8327401: Some jtreg tests fail on Wayland without any tracking bug
  • e77aad9b64028f2a9f88d21721f68faa8ad36b75: 8325616: JFR ZGC Allocation Stall events should record stack traces
  • ed2c4b6894f9bca05f5090c1f295dbc8c2e326f0: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
  • 668fd088d64fff71b8601d0540cc12f7465c2ad7: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
  • 9e8a1c0c937ab3c26f02dd74d956dea01e0bd2fa: 8028127: Regtest java/security/Security/SynchronizedAccess.java is incorrect
  • 9c36bb90ffa0e69e9bb672a4af5357e7f7d9baa0: 8335530: Java file extension missing in AuthenticatorTest

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Sep 26 '24 11:09 openjdk[bot]

@GoeLin Pushed as commit c56241eb2ec17369a9538e9bb3ac30e46c585fd4.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Sep 26 '24 11:09 openjdk[bot]