8273914: Indy string concat changes order of operations

[cushon]

trafficstars

This is a backport of JDK-8273914: Indy string concat changes order of operations.

The patch applied cleanly.

Testing: tier1 langtools tests

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Change requires CSR request JDK-8339881 to be approved
• [x] Commit message must refer to an issue
• [x] JDK-8273914 needs maintainer approval

Issues

• JDK-8273914: Indy string concat changes order of operations (Bug - P4 - Approved)
• JDK-8339881: Indy string concat changes order of operations (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2864/head:pull/2864
$ git checkout pull/2864

Update a local copy of the PR:
$ git checkout pull/2864
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2864

View PR using the GUI difftool:
$ git pr show -t 2864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2864.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273914: Indy string concat changes order of operations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

• 9000e17a95027054353336f531ba64d4f5c80d7e: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
• 593d9d6eed0ef93bbec69763e8924c1f3f79edd6: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
• 676e0491fb41d2f6daf4a29eff54f43d18f5a2ce: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings
• 62e6c68a14885b9e49914f5b40a675f669bf67e1: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent
• 9b15f9f113f5211b466ad754c3c8ddb9c3a949b1: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
• fb8d7fcb08f0e7d34f0c76c1b08c1b21ad30833f: 8340632: ProblemList java/nio/channels/DatagramChannel/ for Macos
• b0e3275a5ec24e68d80ebda8e9fe032789439fc1: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
• cdd2ef284495a5d8b52eecf363bcebcc4f472e93: Merge
• eed263c8077e066a32d746fd188f2dee8c47b9ab: 8341673: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.13
• fbcf4fc81d46f2cace4af479cbb0f165cef1b2b5: 8332644: Improve graph optimizations
• ... and 84 more: https://git.openjdk.org/jdk17u-dev/compare/f18cde4e795988dc22b00fd66713c96185c67275...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[openjdk[bot]]

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

[openjdk[bot]]

⚠️ @cushon This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge[bot]]

Webrevs

• 00: Full (99d8eab5)

[cushon]

/approval request Backporting this change fixes a bug with invokedynamic-based string concatenation. The fix has received real-world testing since 2022, including in JDK 21. The backport applies cleanly. Langtools tier1 tests pass.

[openjdk[bot]]

@cushon 8273914: The approval request has been created successfully.

[cushon]

/integrate

[openjdk[bot]]

@cushon Your change (at version 99d8eab5578c0037638d25ecc56874ef09373de0) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk[bot]]

Going to push as commit 56c03a4a4244c822eec9a45a037465d383a8fafe. Since your change was applied there have been 97 commits pushed to the master branch:

• 3d53c6546214cc55c5e32e9b2eb673fad29cba75: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
• b47abe8e7b4f456b3cb078ae032e96380f8b3802: 8325610: CTW: Add StressIncrementalInlining to stress options
• 6a3c646b41f38d9d761753cc9c17bdc6e4f4b52a: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
• 9000e17a95027054353336f531ba64d4f5c80d7e: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
• 593d9d6eed0ef93bbec69763e8924c1f3f79edd6: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
• 676e0491fb41d2f6daf4a29eff54f43d18f5a2ce: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings
• 62e6c68a14885b9e49914f5b40a675f669bf67e1: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent
• 9b15f9f113f5211b466ad754c3c8ddb9c3a949b1: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
• fb8d7fcb08f0e7d34f0c76c1b08c1b21ad30833f: 8340632: ProblemList java/nio/channels/DatagramChannel/ for Macos
• b0e3275a5ec24e68d80ebda8e9fe032789439fc1: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
• ... and 87 more: https://git.openjdk.org/jdk17u-dev/compare/f18cde4e795988dc22b00fd66713c96185c67275...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@TheRealMDoerr @cushon Pushed as commit 56c03a4a4244c822eec9a45a037465d383a8fafe.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.