jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8302800: Augment NaN handling tests of FDLIBM methods

Open amosshi opened this issue 1 year ago • 4 comments
trafficstars

Backport of JDK-8302800

  • This PR contains two PR
  • commit 1 is made by the git apply which is clean
  • commit 2 adds the missing file test/jdk/java/lang/Math/InverseTrigTests.java currently does not exist in jdk17u-dev, it was originally added by JDK-8302026 via commit

Testing

  • Local: Test passed on MacOS 14.5 on Apple M1 Max
    • CubeRootTests.java: Test results: passed: 1
    • Expm1Tests.java: Test results: passed: 1
    • HyperbolicTests.java: Test results: passed: 1
    • Log10Tests.java: Test results: passed: 1
    • Log1pTests.java: Test results: passed: 1
    • Tests.java: Not applicable: not a test
    • InverseTrigTests.java: Test results: passed: 1
  • Pipeline:
  • Testing Machine:

Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8302800 needs maintainer approval

Issue

  • JDK-8302800: Augment NaN handling tests of FDLIBM methods (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2779/head:pull/2779
$ git checkout pull/2779

Update a local copy of the PR:
$ git checkout pull/2779
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2779

View PR using the GUI difftool:
$ git pr show -t 2779

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2779.diff

Webrev

Link to Webrev Comment

amosshi avatar Aug 03 '24 00:08 amosshi